Bugzilla – Bug 9191
Per window skin settings needed
Last modified: 2008-12-15 12:06:14 UTC
A slight change to the skin mechanism r2860 breaks the per applet skin setting (used for example in the flickr and network test applets). The api used by those applets was broken, as they were adding parameters to the global skin. Another mechanism is needed. I am wondering about a per window skin parameter, that allows skin parameters to be extended/overridden on a per window basis. So for SetupNetTest this would work like: self.window:setSkin({ icon = { ... }, graphtitle = { ... }, ... }) These skin parameters would then only apply to that window. Ben/Triode: does this api sound sensible?
Per window api sound fine - would this override the existing skin or could there also be a case for inheriting from the existing skin and only modifying a few paramters? For the cases which exist I think we need the override existing skin option though.
I'm okay with this plan as well... I think the idea would be full inheritance of existing skin params, with setSkin overriding individual parameters. That at least will be the common case, right?
*** Bug 9716 has been marked as a duplicate of this bug. ***
Fixed in r3261. The skin can override the applet skin setting where required. It is expected that the applet will use it's name for the window style (eg not 'window') to provide a separate namespace per applet.
This bug has been fixed in the 7.3.0 release version of SqueezeCenter! Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already. If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.