Bug 917 – When in Browse menu, pressing PLAY or ADD should play or add the item selected.

Bug 917 - When in Browse menu, pressing PLAY or ADD should play or add the item selected.

Summary:

When in Browse menu, pressing PLAY or ADD should play or add the item selected.

Status:	RESOLVED FIXED

Product:	Logitech Media Server
Classification:	Unclassified
Component:	Player UI
Version:	6.0.0
Platform:	Macintosh All

Importance:	P2 normal (vote)
Target Milestone:	---
Assigned To:	Dan Sully

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2005-03-02 08:24 UTC by Blackketter Dean
Modified:	2008-08-18 10:53 UTC (History)
CC List:	1 user (show)

See Also:
Category:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Blackketter Dean 2005-03-02 08:24:17 UTC

For example, if you are in:

Browse Music
New Music

and you press PLAY, it should play all new music.  Now it jumps to Now Playing, which is incorrect.

Comment 1 KDF 2005-03-10 02:34:23 UTC

The browse_music items used to 'play everything'. this is triggered by a
hardcoded OR for all modes.  BROWSE_BY_NEW_MUSIC wasn't added. However, this
still only does the legacy Play Everything. I'm inclined to think that goig to
now playing is actually a nicer wrong result that playing everything so I'm
leaving it alone for now.  We'll probably need some sort of play command
callback to create a playlist based on these modes and any that might come along.

Comment 2 Blackketter Dean 2005-03-11 17:08:21 UTC

Kevin: can you help dan find the place in Home.pm where he can insert a PLAY handler for each item?

Comment 3 KDF 2005-03-11 17:28:45 UTC

There is an elsif in the 'play' function inside Home.pm, where the test is a
hUGE or string of all teh browse modes.  The result of this just plays
everything, but it could be changed to a case statement that calls
Command::Execute with the right loadtracks parameters.

Comment 4 Dan Sully 2005-03-11 21:10:47 UTC

Fixed! Subversion change 2437.