Created attachment 3808 [details]
Patch to fix support for multiple target platform types

This is with SqueezeCenter r22588.

I have a plugin that wants to indicate that it runs on both Linux and Windows. I've done that with the following in my install.xml:

 <targetPlatform>Linux</targetPlatform>
 <targetPlatform>Windows</targetPlatform>

Unfortunately, with more than one targetPlatform tag present PluginManager can't cope, and fails with the following log entry:

--------------
[11:44:24.3205] Slim::Utils::PluginManager::init (110) Reparsing plugin manifests - manefest checksum differs
[11:44:24.3768] diagnostics::splainthis (594) Warning: Not an ARRAY reference at
        /usr/local/squeezecenter/server/Slim/Utils/PluginManager.pm line 277 (#1)
[11:44:24.3770] diagnostics::splainthis (595) Warning:     (F) Perl was trying to evaluate a reference to an array value, but found
    a reference to something else instead.  You can use the ref() function
    to find out what kind of ref it really was.  See perlref.

[11:44:24.3777] Carp::confess (270) Warning: Uncaught exception from user code:
        Not an ARRAY reference at /usr/local/squeezecenter/server/Slim/Utils/PluginManager.pm line 277. at /usr/local/squeezecenter/server/Slim/Utils/PluginManager.pm line 275
        Slim::Utils::PluginManager::_parseInstallManifest('Slim::Utils::PluginManager', '/usr/local/squeezecenter/server/Plugins/AutoRescan/install.xml') called at /usr/local/squeezecenter/server/Slim/Utils/PluginManager.pm line 218
        Slim::Utils::PluginManager::readInstallManifests('Slim::Utils::PluginManager','ARRAY(0x926b69c)') called at /usr/local/squeezecenter/server/Slim/Utils/PluginManager.pm line 112
        Slim::Utils::PluginManager::init('Slim::Utils::PluginManager') called at /usr/local/squeezecenter/server/slimserver.pl line 413
        main::init() called at /usr/local/squeezecenter/server/slimserver.pl lin
e 462   
        main::main() called at /usr/local/squeezecenter/server/slimserver.pl lin
e 1026
--------------

I believe the code was written to support multiple target platform types, but is wrong. I've managed to fix this with the simple attached patch.