Consider for 7.2.1

replacing the playlist when plugging in was discussed and is "by design". But is it wiped when _un_plugging, too? That would be wrong.

I honestly don't know if it happened when the line in was inserted or removed but having my playlist wiped out never makes me happy. 

If it was plugging in that wiped it, then what does it matter what unplugging does since the list would have already been wiped. You can't unplug without first plugging. Or am I missing something?

At least it must not wipe the playlist if you've decided to play something else while the cable was still plugged in. That's what I was worried about. This must not happen.

As for the "wipe when plugging in" - bug or feature? Only Dean knows ;-).

We could insert the line in item at the current position in the playlist. Would still interrupt playback (which for now is by design). But unplugging would leave you with the same playlist you had when you plugged it in. Thoughts?

Sue - I checked again, and it didn't clear the playlist when unplugging.

The following change would insert the LineIn item to the playlist's current position, instead of replacing the playlist with it:

Index: /Users/mh/Documents/workspace/Boom/server/Slim/Plugin/LineIn/Plugin.pm
===================================================================
--- /Users/mh/Documents/workspace/Boom/server/Slim/Plugin/LineIn/Plugin.pm	(revision 22628)
+++ /Users/mh/Documents/workspace/Boom/server/Slim/Plugin/LineIn/Plugin.pm	(working copy)
@@ -306,8 +306,8 @@
- $client->execute([ 'playlist', 'clear' ] );
- $client->execute([ 'playlist', 'playtracks', 'listRef', [ $obj ] ]);
+ $client->execute([ 'playlist', 'inserttracks', 'listRef', [ $obj ] ]);
+ $client->execute([ 'playlist', 'index', '+1' ]);
 

On unplugging the cable the playlist would continue with the next track.

Ah, I didn't think of someone leaving the line in plugged all the time. Anyway, as long as the previous playlist could continue after the line is unplugged, your proposed solution would be fine. I would expect playback to be interrupted when the line in is attached. Thank you!

The proposed patch doesn't change behaviour when unplugging. This shouldn't interrupt already.

The question is whether the playlist should be cleared when plugging in something or not. That's what this patch addresses.

Dean's call (or Dan's after launch...)

I like the idea of plugging in inserting, rather than playing, the line-in URL for 7.2.1.

Unplugging should remove Line In from the playlist.  

change 22726 - don't wipe the playlist when Line In is plugged in. Insert LineIn playlist item instead, and remove it when unplugging.