Bugzilla – Bug 9112
Last.fm settings menu is useless when no account is registered
Last modified: 2009-09-08 09:20:56 UTC
I don't use last.fm, but I presume I need to register an account somewhere in order for it to do anything. At the moment, I have an entry under Settings for Last.fm Audioscrobbler, but when I select it I just get a single entry saying 'Do not scrobble'. The radio button besides this is selected and can't be deselected. All in all, the entire sub-menu item does absolutely nothing. This is pretty confusing - it would be much better if the Last.fm entry didn't appear at all under Settings unless I'd done whatever I need to do to enable Last.fm, presumably via the web ui.
Andy: What do you think?
Maybe if there's time.
Triode: Do you have a suggestion on the best way to implement this?
add a sub condition to the plugin which is only returns true when you want to see it?
Something like this? (+ whatever is needed for SN) --- Slim/Plugin/AudioScrobbler/Plugin.pm (revision 22608) +++ Slim/Plugin/AudioScrobbler/Plugin.pm (working copy) @@ -186,6 +186,10 @@ } ); } +sub condition { + return ( scalar @{$prefs->get('accounts') || []} ); +} +
Ah thanks, I forgot about condition.
Fixed in change 22651.
Verified fixed in SqueezeCenter 7.2-22900
This bug has been fixed in the 7.3.0 release version of SqueezeCenter! Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already. If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.
Reduce number of active targets for SC