Bugzilla – Bug 9100
play-hold handler not working in many top level dirs
Last modified: 2008-12-15 12:40:02 UTC
mixer play-hold handler doesn't work at misc spots: Music Library->Artists->Mixable Artist Music Library->Albums->Mixable Album however does work for mixable tracks anywhere, as well as Artists->Artist->Mixable album
cometd debug info on one of these queries shows the play-hold handler being sent as 'undef'... base => { actions => { add => { cmd => ["playlistcontrol"], itemsParams => "params", params => { cmd => "add" }, player => 0, }, "add-hold" => { cmd => ["playlistcontrol"], itemsParams => "params", params => { cmd => "insert" }, player => 0, }, go => { cmd => ["tracks"], itemsParams => "params", params => { menu => "trackinfo", menu_all => 1, "sort" => "tracknum" }, }, play => { cmd => ["playlistcontrol"], itemsParams => "params", params => { cmd => "load" }, player => 0, }, "play-hold" => undef, }, window => { titleStyle => "album" }, },
I have a subroutine in Slim::Control::Queries that assembles pulls in data on available mixers: sub _mixers { my $Imports = Slim::Music::Import->importers; my @mixers = (); for my $import (keys %{$Imports}) { next if !$Imports->{$import}->{'mixer'}; next if !$Imports->{$import}->{'use'}; next if !$Imports->{$import}->{'cliBase'}; next if !$Imports->{$import}->{'contextToken'}; push @mixers, $import; } return ($Imports, \@mixers); } I put in some warning messages to dump what $Imports and $mixers were at the time of executing the buildCaches query (the top level albumsQuery and artistsQuery for sending to SBC are built and cached right after SC startup). Turns out they are empty... [08-08-11 14:44:53.7252] Data::Dump::dump (100) Warning: {} [08-08-11 14:44:53.7261] Data::Dump::dump (100) Warning: [] [08-08-11 14:44:55.5773] Data::Dump::dump (100) Warning: {} [08-08-11 14:44:55.5780] Data::Dump::dump (100) Warning: [] [08-08-11 14:44:56.2081] Data::Dump::dump (100) Warning: {} [08-08-11 14:44:56.2088] Data::Dump::dump (100) Warning: [] I'm also seeing this every time when starting SqueezeCenter... [08-08-11 14:44:56.4885] Slim::Plugin::MusicMagic::Plugin::_musicipError (429) bad response from power search filter query my current hunch is that the fix for 8277 has caused this issue. I'm going to back off to a version earlier than that checkin and see if that's the case.
Yep, that's it. Backed off to 22328 and problem disappears. Anyone have an opinion on the course of action? My preference is that we revert and reopen 8277, and retarget that for 8277.
Fixed in change 22521.
Verified fixed in SqueezeCenter 7.2-22900
This bug has been fixed in the 7.3.0 release version of SqueezeCenter! Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already. If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.