Bug 9100 - play-hold handler not working in many top level dirs
: play-hold handler not working in many top level dirs
Status: CLOSED FIXED
Product: SB Controller
Classification: Unclassified
Component: SB Server
: unspecified
: PC Other
: -- normal (vote)
: 7.2
Assigned To: Andy Grundman
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-08-11 07:20 UTC by Ben Klaas
Modified: 2008-12-15 12:40 UTC (History)
4 users (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Klaas 2008-08-11 07:20:06 UTC
mixer play-hold handler doesn't work at misc spots:

Music Library->Artists->Mixable Artist
Music Library->Albums->Mixable Album

however does work for mixable tracks anywhere, as well as Artists->Artist->Mixable album
Comment 1 Ben Klaas 2008-08-11 12:38:10 UTC
cometd debug info on one of these queries shows the play-hold handler being sent as 'undef'...

     base      => {
                         actions => {
                                      add => {
                                            cmd => ["playlistcontrol"],
                                            itemsParams => "params",
                                            params => { cmd => "add" },
                                            player => 0,
                                          },
                                      "add-hold" => {
                                            cmd => ["playlistcontrol"],
                                            itemsParams => "params",
                                            params => { cmd => "insert" },
                                            player => 0,
                                          },
                                      go => {
                                            cmd => ["tracks"],
                                            itemsParams => "params",
                                            params => { menu => "trackinfo", menu_all => 1, "sort" => "tracknum" },
                                          },
                                      play => {
                                            cmd => ["playlistcontrol"],
                                            itemsParams => "params",
                                            params => { cmd => "load" },
                                            player => 0,
                                          },
                                      "play-hold" => undef,
                                    },
                         window  => { titleStyle => "album" },
                       },
Comment 2 Ben Klaas 2008-08-11 12:52:54 UTC
I have a subroutine in Slim::Control::Queries that assembles pulls in data on available mixers:

sub _mixers {
        my $Imports = Slim::Music::Import->importers;
        my @mixers = ();
        for my $import (keys %{$Imports}) {
                next if !$Imports->{$import}->{'mixer'};
                next if !$Imports->{$import}->{'use'};
                next if !$Imports->{$import}->{'cliBase'};
                next if !$Imports->{$import}->{'contextToken'};
                push @mixers, $import;
        }
        return ($Imports, \@mixers);
}

I put in some warning messages to dump what $Imports and $mixers were at the time of executing the buildCaches query (the top level albumsQuery and artistsQuery for sending to SBC are built and cached right after SC startup). Turns out they are empty...

[08-08-11 14:44:53.7252] Data::Dump::dump (100) Warning: {}
[08-08-11 14:44:53.7261] Data::Dump::dump (100) Warning: []
[08-08-11 14:44:55.5773] Data::Dump::dump (100) Warning: {}
[08-08-11 14:44:55.5780] Data::Dump::dump (100) Warning: []
[08-08-11 14:44:56.2081] Data::Dump::dump (100) Warning: {}
[08-08-11 14:44:56.2088] Data::Dump::dump (100) Warning: []

I'm also seeing this every time when starting SqueezeCenter...
[08-08-11 14:44:56.4885] Slim::Plugin::MusicMagic::Plugin::_musicipError (429) bad response from power search filter query

my current hunch is that the fix for 8277 has caused this issue. I'm going to back off to a version earlier than that checkin and see if that's the case.
Comment 3 Ben Klaas 2008-08-11 12:58:20 UTC
Yep, that's it. Backed off to 22328 and problem disappears.

Anyone have an opinion on the course of action? My preference is that we revert and reopen 8277, and retarget that for 8277.
Comment 4 Andy Grundman 2008-08-11 13:52:52 UTC
Fixed in change 22521.
Comment 5 James Richardson 2008-08-27 15:41:17 UTC
Verified fixed in
SqueezeCenter 7.2-22900
Comment 6 James Richardson 2008-12-15 12:40:02 UTC
This bug has been fixed in the 7.3.0 release version of SqueezeCenter!

Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already.  

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.