Bug 9092 – Alarm symbol remains on player even though no individual alarms are enabled

Bug 9092 - Alarm symbol remains on player even though no individual alarms are enabled

Summary:

Alarm symbol remains on player even though no individual alarms are enabled

Status:	CLOSED FIXED

Product:	Logitech Media Server
Classification:	Unclassified
Component:	Player UI
Version:	7.2
Platform:	PC Windows XP

Importance:	-- normal (vote)
Target Milestone:	7.x
Assigned To:	Max Spicer

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2008-08-10 00:52 UTC by Philip Meyer
Modified:	2009-07-31 10:26 UTC (History)
CC List:	1 user (show)

See Also:
Category:	---

Attachments
Fix (698 bytes, patch) 2008-08-11 12:46 UTC, Max Spicer	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Philip Meyer 2008-08-10 00:52:23 UTC

I had one alarm, which was not set to repeat.

The alarm went off, and the individual alarm was therefore set to "Off".  "All Alarms" was "On".

However, when I turned the player off, the date time screensaver still shows the alarm symbol, even though there's no alarm configured to go off.

Comment 1 James Richardson 2008-08-11 09:25:00 UTC

Max: Can you have a look at this?

Comment 2 Max Spicer 2008-08-11 09:27:36 UTC

There were a few bugs with the repeat alarm setting which have now been fixed.  It's quite possible that the alarm symbol was correct i.e. the alarm was actually set to go off.  Could you please confirm whether you still see this issue with the latest version?

Comment 3 Chris Owens 2008-08-11 10:08:54 UTC

Ping Philip

Comment 4 Max Spicer 2008-08-11 11:08:44 UTC

I've managed to reproduce this myself and so will take a look to work out what's going on.

Comment 5 Max Spicer 2008-08-11 12:45:47 UTC

Okay, I've worked out what is causing this.  The attached patch should fix it.  The problem was only with the display of the next alarm - it wouldn't have actually sounded.  I've had a good think about the implications of this change and am almost certain that it's safe.  However, I am slightly nervous about it as it is to the alarm scheduling code, which hasn't needed any changes for a long time and proved to have many odd edge cases to handle when I was designing it.  I've done what limited testing I can and it seems to work, but more testing would be very welcome.

CC-ing Chris for a decision on whether to commit to 7.2.

Comment 6 Max Spicer 2008-08-11 12:46:47 UTC

Created attachment 3777 [details]
Fix

Comment 7 Chris Owens 2008-08-11 14:13:01 UTC

Yes please commit it.  Thanks!

Comment 8 Max Spicer 2008-08-12 01:00:58 UTC

Committed in change 22530.  This should hopefully fix the issue.

Comment 9 James Richardson 2008-08-27 10:52:24 UTC

Verified fixed in
SqueezeCenter 7.2-22900

Comment 10 James Richardson 2008-12-15 12:34:48 UTC

This bug has been fixed in the 7.3.0 release version of SqueezeCenter!

Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already.  

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.

Comment 11 Chris Owens 2009-07-31 10:26:50 UTC

Reduce number of active targets for SC