Bugzilla – Bug 9091
Mixer icon is not shown at all
Last modified: 2009-09-08 09:32:06 UTC
The underlined "m" symbol, indicating if mixers are available for a given item is not displaying at all. I have tried browsing artists, albums, songs in Browse menus and by drilling down from the currently playing track. I have tried removing all third-party plugins, just in case. The items are mixable; if I press and hold play, I get the MusicIP mix settings screen.
Would you mind sharing with us about what UI you're talking? Version numbers? Browser version (if talking about the web UI)? etc.
Ok, you must be talking about the player interface. I do not even know anymore where it used to be... But I guess it might be due to some recent display code change Triod did?
I don't believe I've changed anything which would impact this, but as I don't use MusicIP I can't be sure. Can you give more details of which screen and where it used to show up?
Yes, I am talking about the player UI (I picked that as the component for this bug?). The "m" (underlined) symbol used to appear in the top-right corner of the display when browsing to any artist, album, song, genre or year item, pretty much anywhere in the player UI, if there are any mixers available for the item (eg. MusicIP). I think I've found the problem. If "Show Menu Count" is set to "Always", the "m" mixer icon never appears. If "Show Menu Count" is "Whilst Scrolling", the "m" will be displayed after X of Y disappears from the display.
OK understand now. Dean - This is a consquence of X of Y to the the top right hand corner. It will be seen for all existing players as the default is not to hide X of Y. What we could do is add the mixable icon in front of the X of Y on the display. Alternatively we leave as is or change the default. How many people use this?
A lot of people expect the "m"; it's been there a long long time to indicate when play.hold action is available to invoke mixers.
hm, the law of unintended consequences. I almost want to say that the 'm' belongs on the second line, before the left arrow/note symbole, not the first line, since it's related to the item, not the list, but that's probably a little late to make that change at this point. I'd say, otherwise, that the m should precede the "1 of 10" string. reactions?
If it is decided to go on line 2, be careful as this font can be bigger. Instead of an underlined m character, you'd probably need a new fixed size icon to appear just before/after the arrow. Could go before or after X of Y on the top line.
Dean - its as easy to put it on the second line as the first. A grep through the code shows it is only added in one place - during browsedb button mode. Looks ok to me on the second line. Which would you like? More intesting is the MusicMagic plugin which seems to put string MUSICMAGIC_MIXRIGHT on the top right in some of its setting mode. I can't see how this could be easily moved. Any views?
Update to this - if we add it to the top line, then the icon will move depending on the width of the X of Y text - it can't go after the X of Y as this means that moving between items which are mixable and not moves the X of Y, if it goes before it will move based on the width of X. Also it looks very odd if you enable hiding of X of Y as the icon moves - this would be the default on boom. Putting on the second line gives a larger icon which is more visible. The downside is this uses more screen width on boom. I'll add it to the second line and see if people like it...
moved mixable icon to second line in change 22520 to see how people like it. MusicMagic settings do not look to be a problem as I don't think they show X of Y but I can't test so it would be useful if someone could test the settings menu in Slim::Plugins::MusicMagic::PlayerSettings.
It sure is ugly having the "m" on the second line, especially when changing the font size. In large font, the "m" and "->" take up half the screen! To me, the "m" belongs on the top line, where it always used to be. I think the top line used to have "menu option (X of Y)" on the left, with "m" appearing on the right if appropriate. I think the change has been to put X of Y on the right, so that it is not hidden when the menu text (eg. an artist, album, song title, etc), is too long. I don't know why "m" should have moved, especially seeing we are trying to save space, not waste space! MusicIP player settings are a problem. They do display X of Y correctly on the right when displaying the set of settings that can be configured, i.e. the options (n of 8) are: 1. MusicIP Mix Size 2. MusicIP Mix Type 3. MusicIP Mix Style 4. MusicIP Mix Variety 5. MusicIP Mix Filter 6. MusicIP Mix Genre 7. MusicIP Reject Type 8. MusicIP Reject Size However, options 1, 3, 4 and 8 then display slider controls, but there is not enough display width to display the "setting title(number)" of the left with "(GO RIGHT TO MIX)" on the right on the top line, so the important bit (number) isn't visible.
I was afraid of that. Can we try the m on the top line to the right of the numbers?
change 22557 puts the icon on the top line to the left of X of Y. The reason for this is that if it goes on the right then X of Y moves depending on whether the desplayed item is mixable (the text + icon string is always right justified) - this looks odd. Does this look ok to people?
Re the MM settings menu - change 22560 is the best that can be done without changing the strings. Assuming people are happy with these changes, I will reassign to Michael to get the strings shortened post 7.2.
It looks okay to me, although I did prefer the display when the (X of Y) was after the item on the left, leaving the "m" clearly displayed on the right. It probably seems odd for newcomers, as the "m" is really associated with the item on the second line. It could do with documentation in the manual to explain what the symbol means, if it isn't already in there.
Ok - so I'm considering the icon side of this closed. Michael - this leaves the settings strings. The EN ones just about fit on the boom display, but both they and the non EN ones could do with shortening. Handing the bug to you and leaving you to retarget.
just be sure: it's SETUP_SHOWCOUNT we're talking about here?
No - all the strings which appear on the top left in setup mode: SETUP_MIX_SIZE, SETUP_MIX_TYPE, SETUP_MIX_STYLE, SETUP_MIX_VARIETY, SETUP_MIX_FILTER, SETUP_MIX_GENRE, SETUP_REJECT_TYPE, SETUP_REJECT_SIZE (as per Phil's list earlier on in this bug) They are referenced in Slim::Plugins::MusicMagic::PlayerSettings
First I didn't understand the issue, because I was testing on Boom. And there's no overlapping string, because a right arrow is used instead. Only when testing on SB3 I saw the overlapping text. Why don't we use the same arrow on SB3 as well? I couldn't imagine how to reasonably change eg. the German string to fit in there.
Created attachment 3823 [details] Strings overlapping on SB3 (German) A screenshot to show how the strings are still too long on SB3/Transporter
Created attachment 3824 [details] smaller display with icon
change 22741 - use play icon on all players - the MIXRIGHT string often overlaps value in eg. German.
Verified fixed in SqueezeCenter 7.2-22900
This bug has been fixed in the 7.3.0 release version of SqueezeCenter! Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already. If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.