Bug 9086 - Controller doesn't show player brightness or text size choices for players w/display
: Controller doesn't show player brightness or text size choices for players w/...
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Player UI
: unspecified
: PC Windows Vista
: -- normal (vote)
: ---
Assigned To: Blackketter Dean
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-08-09 08:19 UTC by Doug Williams
Modified: 2009-09-08 09:14 UTC (History)
0 users

See Also:
Category: ---


Attachments
three brightness options as sliders (4.75 KB, patch)
2008-08-11 23:32 UTC, KDF
Details | Diff
brightness settings as radio buttons (13.93 KB, image/png)
2008-08-12 06:38 UTC, Ben Klaas
Details
new display settings submenu and player brightness menus (139.82 KB, image/png)
2008-08-12 11:14 UTC, Ben Klaas
Details
new player text size menus (76.82 KB, image/png)
2008-08-12 11:15 UTC, Ben Klaas
Details
player brightness and text size settings when connected to boom (23.11 KB, image/png)
2008-08-12 11:15 UTC, Ben Klaas
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Doug Williams 2008-08-09 08:19:22 UTC
Not sure that this is in the correct place, but it is the most secure so I'm putting it here.

On the controller if you go to Setting, Advanced you see a "Player Brightness" option with a ">" after it.  If you select this then the boom's brightness is decreased by one.  There should be a sub menu where the user can see the choices and select the preferred one.  

Also the current pop up just shows brightness levels 6 through 0 instead of the more desriptive labels.

Also doesn't have the "while on" and "While off" and "idle" sub-options, either.
Comment 1 Chris Owens 2008-08-11 09:21:00 UTC
The menu should match the boom ui
Comment 2 KDF 2008-08-11 23:32:42 UTC
Created attachment 3781 [details]
three brightness options as sliders

a few minor issues left.  It needs access to $client->maxBrightness and there are warnings on 'weight' and 'splice' when the queries are made at jive startup.

hopefully the initial legwork is a small timesaver.
Comment 3 Ben Klaas 2008-08-12 06:38:21 UTC
Created attachment 3784 [details]
brightness settings as radio buttons

hmmm...I was about 3/4 of the way into implementing these settings as radio buttons. I really like the idea of using a slider (heh, someone's actually paying attention to jiveMLON feature additions), but in Boom there's a slight problem because a brightness level of 6 on Boom is actually "automatic" rather than "maximum". If it weren't for that I'd say using a slider would be the way to go.

Opinions anyone?
Comment 4 Ben Klaas 2008-08-12 06:39:02 UTC
Dean, can you take a quick peak at the discussion here and comment?
Comment 5 Ben Klaas 2008-08-12 08:19:35 UTC
I implemented this as radio buttons in change 22541.

I'm amenable to changing this to a slider, but I think the 'automatic' setting 6 for Boom makes that probably not the right choice.

Comment 6 Blackketter Dean 2008-08-12 10:32:13 UTC
Ben: Is the PNG representative of the final UI?  I'd say that the order should be reversed (Automatic, Brightest... Dimmest).

Comment 7 Ben Klaas 2008-08-12 10:52:15 UTC
sure, I'll reverse the order...

I think Player Text Size is also a needed setting on the controller UI, esp. with Boom since the included IR remote doesn't have a text size button.

The wiki for the UserInterfaceHierarchy is actually screwed up in this section, as it assumes that Controller Screen/Player Display are an either/or proposition, when in fact the Controller needs both when connected to a player with a display.

I propose this organization, and will have a checkin shortly for it:

Settings->
        ...
        Screen->
                Brightness->
                Screen Dimming->
                Screensavers->
                Wallpaper->
        Player Display->
                Brightness->
                Text Size->
        ...

Only problem right now is I have no string for PLAYER_DISPLAY, only DISPLAY_SETTINGS (EN = "Display"). This leaves the item as being fairly ambiguous as to whether it's for the controller or a player. Not sure what to do on that point for 7.2 though.

Comment 8 Ben Klaas 2008-08-12 10:53:09 UTC
generalizing summary to all players for clarity
Comment 9 Ben Klaas 2008-08-12 11:02:06 UTC
change 22553 has the reversed order, a new setting for Text Size, and a new submenu Settings->Display to contain the two items.

I'll post some screenshots in a bit
Comment 10 Ben Klaas 2008-08-12 11:14:36 UTC
Created attachment 3790 [details]
new display settings submenu and player brightness menus

note: this is when connected to an SB3
Comment 11 Ben Klaas 2008-08-12 11:15:10 UTC
Created attachment 3791 [details]
new player text size menus

note: connected to SB3
Comment 12 Ben Klaas 2008-08-12 11:15:44 UTC
Created attachment 3792 [details]
player brightness and text size settings when connected to boom
Comment 13 Ben Klaas 2008-08-12 11:16:30 UTC
Dean, assigning to you for assessment. If this works for you, close it...
Comment 14 James Richardson 2008-08-26 16:03:35 UTC
Verified fixed in
SqueezeCenter 7.2-22900
Controller 7.2 2873
Comment 15 James Richardson 2008-12-15 11:59:11 UTC
This bug has been fixed in the latest release of SqueezeCenter!

Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already.  

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.