Bugzilla – Bug 9074
Button add (+) doesn't clear current playlist anymore
Last modified: 2009-09-08 09:27:49 UTC
While in the top level of the player UI (when it reads Home - Now Playing 1 of x) it is no longer possible to clear the current playlist by pressing add (+) on either the remote or front panel button. The only thing that happens is the same as pressing right on the remote - one gets transferred to the current playlist. BTW: While in current playlist, pressing add (+) still removes one song just fine.
by request - bug 8929
well, in that other bug Dean says: "ADD can also go right, if there's no other function specified..." I believe in that specific situation ADD did clear the complete playlist. Don't get me wrong, if we have decided to remove that functionality, that's fine with me. I only realized it, because I often was clearing the playlist like this.
Ah, I forgot about that shortcut. People do use it (and I think it's in the user guide.) Let's fix.
Just revert the add functionality or the play functionality too - as I think the same case will be true of people being used to the old operation? For reference the old code is: 'add' => sub { my $client = shift; if ($client->curSelection($client->curDepth()) eq 'NOW_PLAYING') { $client->showBriefly( { 'line' => [ "", $client->string('CLEARING_PLAYLIST') ] }); $client->execute(['playlist', 'clear']); } else { Slim::Buttons::Common::pushModeLeft($client,'playlist'); } }, 'play' => sub { my $client = shift; my $selection = $client->curSelection($client->curDepth()); if ($selection eq 'NOW_PLAYING') { $client->execute(['play']); Slim::Buttons::Common::pushModeLeft($client, 'playlist'); } elsif ($selection eq 'SAVED_PLAYLISTS' || ($selection =~ /^BROWSE_/ && $selection ne 'BROWSE_MUSIC')) { # If we're in a Browse mode and the user # presses play, just go right, per Dean Slim::Buttons::Input::List::exitInput($client, 'right'); } else { Slim::Buttons::Common::pushModeLeft($client, 'playlist'); } },
Created attachment 3763 [details] restore shortcut just restores the 'add' shortcut when on the Now Playing item in the top level.
Excellent. Will you commit?
done, change 22481. no changelog entry as the bug was within 7.2 only.
Verified fixed in SqueezeCenter 7.2-22900
This bug has been fixed in the 7.3.0 release version of SqueezeCenter! Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already. If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.
Reduce number of active targets for SC