Bug 907 - pressing buttons while player is in standby makes things blip on to the screen
: pressing buttons while player is in standby makes things blip on to the screen
Status: CLOSED FIXED
Product: SB 2/3
Classification: Unclassified
Component: SB Server
: unspecified
: Macintosh All
: P2 normal (vote)
: ---
Assigned To: Blackketter Dean
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-03-01 17:04 UTC by Kevin Pearsall
Modified: 2008-12-15 11:56 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Pearsall 2005-03-01 17:04:43 UTC
tested this with a squeezebox-1-g and it doesn't happen.

but when in standby with sb2 pressing any of the following causes stuff to come
on to the screen briefly before going back to the standby clock screen:
- now playing
- sleep
- shuffle
- repeat
- sleep
- search
- any of the numbers
- any of the arrows
- add
- play
- vol up/down

on sb-1-g the only buttons that do anything are search and play.
Comment 1 Blackketter Dean 2005-03-04 14:18:03 UTC
Hm, weird.  For example, I added:

shuffle					= dead
shuffle_toggle			= dead
shuffle.*				= dead
shuffle_off				= dead
shuffle_on				= dead

to the [off] section in Default.map and I still see shuffle behavior when off.  Robert:  what am I missing 
here?
Comment 2 Robert Moser II 2005-03-06 19:32:08 UTC
What do you get from --d_ir and --d_command?
Comment 3 Robert Moser II 2005-03-07 10:53:41 UTC
OK, I've got the problem figured out.  We aren't really in the 'off' mode, which
is why the mappings aren't doing anything.  Instead we are in the
'SCREENSAVER.datetime' mode, unless of course you have changed your offsaver
preference.

Not sure what to do about this.
Comment 4 KDF 2005-03-07 16:25:06 UTC
how about checking $client->power in the IR handling?
Comment 5 Robert Moser II 2005-03-07 16:33:04 UTC
Bleh, I don't really want to have to check the power status every time a button
is pressed.

I'm thinking that we should have SCREENSAVER.* functions also register an OFF.*
mode.  So SCREENSAVER.datetime, when it registers itself, also generates an
OFF.datetime mode.  When the screensaver kicks in while !$client->power(), it
goes to the OFF variant rather than the SCREENSAVER variant.  This takes
advantage of the existing code in IR.pm to funnel everything through the off
mode, unless explicitly mapped as OFF.datetime.

Then the remaining problem is getting play working again to take you out of the
power-off state.  That can be solved by mapping play to modefunction_off->play
(I think, I haven't tested the mapping part).
Comment 6 Robert Moser II 2005-03-08 15:56:33 UTC
Fixed in r2374 using scheme mentioned.
Comment 7 Kevin Pearsall 2005-03-21 10:51:40 UTC
behaves like sb1 now, thanks
Comment 8 James Richardson 2008-12-15 11:56:43 UTC
This bug has been fixed in the latest release of SqueezeCenter!

Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already.  

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.