Bug 9048 - Reset player preferences - confirmation JS dialog needed
: Reset player preferences - confirmation JS dialog needed
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Web Interface
: 7.2
: All All
: -- normal (vote)
: 7.x
Assigned To: Michael Herger
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-08-05 15:21 UTC by Jim McAtee
Modified: 2009-07-31 10:26 UTC (History)
0 users

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jim McAtee 2008-08-05 15:21:23 UTC
This is one of those things in the web UI that should have a user confirmation JS dialog.  It's a little too easy to hit the link and there's no feedback given to the user beyond reloading the page.

Also, it should be effected through a button executing a POST instead of a link.  A link appears as though it might lead to another page and an http GET shouldn't have side effects that change data (prefs).

http://www.rfc.net/rfc2616.html#s9.1.1

"In particular, the convention has been established that the GET and
 HEAD methods SHOULD NOT have the significance of taking an action
 other than retrieval. These methods ought to be considered "safe".
 This allows user agents to represent other methods, such as POST, PUT
 and DELETE, in a special way, so that the user is made aware of the
 fact that a possibly unsafe action is being requested."
Comment 1 Michael Herger 2008-08-12 01:32:03 UTC
change 22533 - make the "Reset Player" a button with confirmation dialog instead of a simple link
Comment 2 James Richardson 2008-08-26 15:39:55 UTC
Verified fixed in
SqueezeCenter 7.2-22900
Comment 3 James Richardson 2008-12-15 12:34:43 UTC
This bug has been fixed in the 7.3.0 release version of SqueezeCenter!

Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already.  

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.
Comment 4 Chris Owens 2009-07-31 10:26:36 UTC
Reduce number of active targets for SC