Bugzilla – Bug 9002
SC 7.1.0 not importing pre-existing MIP playlists.
Last modified: 2009-09-08 09:27:54 UTC
I just upgraded SC 7.0.1 to SC 7.1.0 (on Win XP SP3). MIP 1.9 MIP Plugin checked. Basic Settings/ Music Folder is blank. Advanced/MIP/Reload Interval set to 0 SC 7.1.0 initiated a "Clear and Rescan" of my library as part of the upgrade. It picked up all 29,000 tracks but did not find the playlists in MusicIP. I restarted the computer, confirmed that I can create a MusicIP mix in SqueezeCenter (in other words the MusicIP plugin works) and then initiated a "rescan playlists only". Again the MusicIP playlists did not appear in SqueezeCentre. SC 7.0.1 picked up the playlists in MusicIP and called them "MusicIP: Playlist Name" To demonstarte this bug this, make a mix in MIP and name it "Test Mix", then do a "Rescan playlists only". If you are running SC7.0.1 it will appear in playlists as "MusicIP: Test Mix". If you are running SC7.1.0 the playlist will not appear. I upgraded a second system (in my wife's house) (WinXP SP3) from SC 7.0.1 to SC 7.1.0 and once more playlists in MIP were not picked up by the scan process. The workaround is to save the playlists in MIP using the "Save as playlist" function then do a "Rescan playlists only" in SC. The Rescan Playlists Only is very fast, 15 seconds on my computer to rescan the playlists followed by 10 minutes of housekeeping. However Playlists can be viewed after the first step = i.e. 20 seconds after starting the rescan. I have reported this via email to support SC 7.1.0 Not scanning MusicIP Playlists [Incident: 080730-001709]
QA to reproduce for 7.3
Renaming a product is a bad idea. We still have some issues of musicip vs. musicmagic. The following patch should fix the MIP playlist issue. Index: /Users/mh/Documents/workspace/Boom/server/Slim/Schema/ResultSet/Playlist.pm =================================================================== --- /Users/mh/Documents/workspace/Boom/server/Slim/Schema/ResultSet/Playlist.pm (revision 22786) +++ /Users/mh/Documents/workspace/Boom/server/Slim/Schema/ResultSet/Playlist.pm (working copy) @@ -97,7 +97,7 @@ if ($prefs->get($importer)) { - push @playlists, $Slim::Music::Info::suffixes{sprintf('%splaylist:', $importer)}; + push @playlists, $Slim::Music::Info::suffixes{sprintf('%splaylist:', $importer eq 'musicip' ? 'musicmagic' : $importer)}; } } } Chris - I'd like to consider this change for 7.2 (or at least 7.2.1).
Created attachment 3839 [details] The real deal: replace musicmagicplaylist with musicipplaylist The real solution to this problem is getting rid of some more musicmagic traces: rename the playlist type to musicipplaylist instead of musicmagicplaylist.
Is there a reason I can't figure out for this bug to be limited visibility?
Dean/Chris - are you ok adding this fix to 7.2? IMHO there are quite a few users out there who use MIP to create playlists in the MIP UI.
change 22824 - fix MIP playlist import. This is the quick fix. We'll have to do the real cleanup post 7.2.
change 22838 - change musicmagicplaylist to musicipplaylist (7.3 only) Will have to review once 7.2 is fully merged. Will need one more change in Music::Info::isRemoteURL()
I just upgraded to SC 7.2.0 and ran a "Rescan Playlists only" and the MIP playlists appeared in SC under playlists. So, this is resolved as far as I'm concerned (but as 60 year old who started coding in IBM Assembler in the 1960s I can understand that this is a quick & dirty fix and the developers want to tidy it up).
thanks for the feedback
This bug has been fixed in the 7.3.0 release version of SqueezeCenter! Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already. If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.
Reduce number of active targets for SC