Bug 8981 - Sync'd players & Line IN oddity
: Sync'd players & Line IN oddity
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Player UI
: unspecified
: All Other
: P3 normal (vote)
: ---
Assigned To: Alan Young
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-08-01 09:30 UTC by James Richardson
Modified: 2009-09-08 09:28 UTC (History)
5 users (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description James Richardson 2008-08-01 09:30:21 UTC
When I have players synced, and I tell 1 player to switch to "line-in" then ALL players switch to Line-In.

Even those players like the Duet that do not have a line in, or the Transporter which have Multiple Line In's.

What should be the expected behavior when all players are synced and 1 is told to switch to line-in?
Comment 1 Blackketter Dean 2008-08-02 10:32:05 UTC
It should be removed from the group, like it was powered off.
Comment 2 James Richardson 2008-08-02 11:11:29 UTC
So the 1 player should be removed from the group, and the rest of the group should continue to play, correct?

I couldn't find a spec page on this, can you link it for me please.
Comment 3 Chris Owens 2008-08-04 09:57:08 UTC
I thought we were talking that line in ought to be mixed with song playback.  In that case it would make good sense to be able to sync and have line in active.  Is that not the plan?

cc'ing Alan as well.
Comment 4 Blackketter Dean 2008-08-05 07:34:41 UTC
We decided to punt on mixing by default for the first release, though add it as an option.

I think that if a player is set to Line In, it should drop from a sync group (like if you power off).

No spec for this yet, as you just discovered this case.  :)

Alan: Can you take a look at this?
Comment 5 Alan Young 2008-08-13 07:59:49 UTC
I propose to cause (a) the auto-play of line-in in when plugged in, and (b) play from the UI menu item: to force the player out of any sync group first. This will be a permanent unsync, not temporary.

For 7.3 I would add a check in overridePlayback to fail and display an error if trying to play line-in when synced (via favourites, for example).
Comment 6 Chris Owens 2008-08-13 09:18:47 UTC
I think Dean's current thinking for the behavior of the line-in detection is just to make the line-in option also appear on the device home menu, in addition to its usual location in the menu structure.  IIRC Ben is working on this.
Comment 7 Alan Young 2008-08-14 23:31:23 UTC
Change 22623 as described in comment #5.
Retarget to 7.3 for remaining changes.
Comment 8 Blackketter Dean 2008-08-16 22:27:39 UTC
I don't think we need an error warning here, let's just have some reasonable, intuitive default behavior (i.e. permanent or temporary unsync.)

Closing, but let's keep an eye on customer feedback on the behavior.
Comment 9 Alan Young 2008-08-16 23:08:00 UTC
The current change means that if you switch to line-in via the UI or as a consequence of plugging in the jack, then the player is automatically, silently and permanently unsynced (if it was synced in the first place). This is fine, in my opinion. It works because the command to play line-in is interpreted in the context of a specific (line-in-capable) player.

If, however, (for a synced player) you try to play line-in via favourites, tune-in-URL or from a playlist - anything that just presents a line-in URL to the streaming-control code (old or new streaming) - then the results are unpredictable, and to some extent always wrong. This is because the command to play line-in is interpreted in the context of the sync-group, more-specifically the sync-group master. It may be that the sync-group master (unpredictable from a user point of view), can play line-in, in which case the master will play-line and the others will play nothing. Other scenarios lead to internal errors. No useful user feedback is given.

My proposal was to detect this second situation - trying to play line-in (or digital-in) via a URL when synced - and generate a user-visible error.
Comment 10 Blackketter Dean 2008-08-17 07:33:11 UTC
If we moved to the Line-In-is-always-on model, then this would be moot. 

Alan: is there any way to disambiguate what player context triggered the line in URL request?

Of course, the best solution would be to stream the line in to the other players over the network.  :)
Comment 11 Alan Young 2008-08-17 09:23:06 UTC
No, not easily. Of course, it is only software ...

There are several use-cases where streaming out to other players would be useful.
Comment 12 James Richardson 2008-08-22 13:25:24 UTC
This appears to be addressed in
SqueezeCenter 7.2-22834
Comment 13 James Richardson 2008-12-15 11:59:03 UTC
This bug has been fixed in the latest release of SqueezeCenter!

Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already.  

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.