Bug 8974 - Alarm changes lost in web ui when player is changed without clicking apply
: Alarm changes lost in web ui when player is changed without clicking apply
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Web Interface
: unspecified
: All All
: P3 normal (vote)
: 7.x
Assigned To: Michael Herger
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-07-31 14:07 UTC by Max Spicer
Modified: 2009-09-08 09:15 UTC (History)
2 users (show)

See Also:
Category: ---


Attachments
trigger validation when slider is used to change value (1.51 KB, patch)
2008-08-27 00:43 UTC, Michael Herger
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Max Spicer 2008-07-31 14:07:19 UTC
I keep loosing changes to alarms in the web ui as I make the changes then select another player in the drop-down list, forgetting to click Apply.  Ideally they'd save when I change player.

This is far too easy to do - the Apply button is just too distanced from everything else in my opinion.
Comment 1 KDF 2008-07-31 14:23:54 UTC
so, really this is an issue for ALL of the settings pages, yes?
Comment 2 Michael Herger 2008-07-31 15:36:34 UTC
By convention you have to hit Apply. This was discussed during the web UI redesign. Same for all pages.

The bug here is that you don't get a warning before changing.
Comment 3 Michael Herger 2008-08-04 01:48:04 UTC
change 22336 - always ask whether changes should be saved before changing settings page. This was only implemented for changing tabs, but not sub-items.
Comment 4 James Richardson 2008-08-26 14:05:22 UTC
Fixed for Windows

Still Broken for MAC:  Changing focus from the Player tab to Music Library tab will not prompt to save settings.  
Comment 5 James Richardson 2008-08-26 14:08:44 UTC
In the Windows Version, changing focus from Player tab to Music Lib tab will prompt a save.

Also, changing focus with-in the player tab from Alarm to Audio will prompt a save.

In the Mac Version, only changing the focus with-in the player tab will prompt a save.  I.E. Alarm to Audio will prompt.
Comment 6 Michael Herger 2008-08-26 19:43:00 UTC
Please define what browsers you're using. This is not a platform issue, but a browser issue. I'm developping on Mac - believe me when I say it's working fine on Mac.
Comment 7 Michael Herger 2008-08-27 00:03:07 UTC
Ok, I think this is neither OS nor browser, but _what_ you change. I noticed it would correctly capture the change in time, playlist etc., but not values changed using the sliders. If you change the same values manually, typing in a new value, you'll be warned before changing the page.

I'll try to come up with a fix for this, but I'm not sure this will make it for 7.2.0.
Comment 8 Michael Herger 2008-08-27 00:43:32 UTC
Created attachment 3898 [details]
trigger validation when slider is used to change value
Comment 9 Michael Herger 2008-08-27 00:46:04 UTC
Dean/Chris - should this patch be included in 7.2.0? Nothing seriously broken without it, just not asking whether you want to save changes if you've been using sliders only.

James - did you see other than slider changes which didn't trigger the confirmation?
Comment 10 Michael Herger 2008-08-27 03:56:13 UTC
change 22921 - checked patch in to 7.2.1. 

James - does this fix the issue you've seen?
Comment 11 James Richardson 2008-08-27 09:14:15 UTC
Appears to be working as expected now, thanks for the quick fix :)
Comment 12 James Richardson 2008-12-15 12:34:36 UTC
This bug has been fixed in the 7.3.0 release version of SqueezeCenter!

Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already.  

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.
Comment 13 Chris Owens 2009-07-31 10:26:18 UTC
Reduce number of active targets for SC