Bug 8972 - Alarm sliders in web ui allow non-numeric inputs
: Alarm sliders in web ui allow non-numeric inputs
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Player UI
: unspecified
: All All
: -- normal (vote)
: ---
Assigned To: Michael Herger
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-07-31 13:53 UTC by Max Spicer
Modified: 2008-12-15 11:59 UTC (History)
0 users

See Also:
Category: ---


Attachments
Add validators to alarm prefs (638 bytes, patch)
2008-07-31 13:53 UTC, Max Spicer
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Max Spicer 2008-07-31 13:53:40 UTC
Created attachment 3721 [details]
Add validators to alarm prefs

You can enter non-numeric values for the slider controls in the alarm web ui.  Example, you can set snooze time to zz.  This probably shouldn't be possible even without underlying preference validators defined.

The attached patch sets pref validators for the underlying prefs, but this still doesn't quite fix the problem.  The red/green js validation in the web ui only seems to apply if both low and high values are defined for intlimit.  As a result, entering zz gets a red input field for volume, but not for snooze length or timeout.
Comment 1 Michael Herger 2008-08-04 02:39:41 UTC
change 22339 - sanity check input values for sliders, don't accept non-numerical values (this is not limited to alarm use, but any slider input)
Comment 2 Michael Herger 2008-08-04 03:59:32 UTC
change 22341 - added your validators to the backend. They don't work nicely in the web UI though, as the seconds based values are translated to minutes in the web UI.
Comment 3 James Richardson 2008-08-26 14:02:34 UTC
Verified fixed in
SqueezeCenter 7.2-22900

NOTE: Sliders are available in the MAC build but not the Windows build
Comment 4 Michael Herger 2008-08-26 19:41:15 UTC
Sliders are platform independant. Only IE6 can't display them. Should be fine on any other browser.
Comment 5 James Richardson 2008-12-15 11:59:02 UTC
This bug has been fixed in the latest release of SqueezeCenter!

Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already.  

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.