Bug 8958 – File Version information missing from Windows Installer

Bug 8958 - File Version information missing from Windows Installer

Summary:

File Version information missing from Windows Installer

Status:	CLOSED FIXED

Product:	Logitech Media Server
Classification:	Unclassified
Component:	Windows Installer
Version:	7.1
Platform:	PC Windows XP

Importance:	P3 minor (vote)
Target Milestone:	7.x
Assigned To:	Michael Herger

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2008-07-31 08:24 UTC by James Richardson
Modified:	2009-07-31 10:26 UTC (History)
CC List:	3 users (show)

See Also:
Category:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description James Richardson 2008-07-31 08:24:05 UTC

If I look at the properties for the Windows Installer of SC, I notice that the FIle Version Information is 0.0.0.0.  It should be the full version string of 7.1 - 22170

Comment 1 Michael Herger 2008-08-04 07:46:37 UTC

Matt - I thought I'd be able to do this in the installer compiler. But as it would need to install and configure a pre-compiler to merge the version strings into the .iss file. Thus I wondered whether we couldn't simply do a sed or 

s/(VersionInfoNumber=)0.0.0.0/$1$revision/

on the .iss file in the build script. What do you think?

Comment 2 Matt Wise 2008-08-04 07:50:57 UTC

Michael,
  I don't see a reason why that wouldn't be fine... just make the change in the buildWIn32() section of the build script...

Comment 3 Michael Herger 2008-08-04 10:26:57 UTC

change 22354 - have the build script pre-process the installer script to include the revision number.

Comment 4 James Richardson 2008-08-05 10:16:40 UTC

Verified fixed in
SqueezeCenter 7.2-22374

Comment 5 James Richardson 2008-12-15 12:34:35 UTC

This bug has been fixed in the 7.3.0 release version of SqueezeCenter!

Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already.  

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.

Comment 6 Chris Owens 2009-07-31 10:26:15 UTC

Reduce number of active targets for SC