Bug 8955 - Move All Alarms On/Off below Add Alarm in player ui
: Move All Alarms On/Off below Add Alarm in player ui
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Player UI
: unspecified
: All All
: -- normal (vote)
: ---
Assigned To: Michael Herger
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-07-31 06:16 UTC by Max Spicer
Modified: 2009-09-08 09:24 UTC (History)
3 users (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Max Spicer 2008-07-31 06:16:40 UTC
Dean suggests moving All Alarms On/Off below Add Alarm in the player ui.  This means that new users would see Add Alarm first, which is good.  Unfortunately however, this means that All Alarms could be off but you wouldn't notice.  You could then add a new alarm with no idea that it won't actually go off.

I did consider re-enabling all alarms when a new alarm is added, but this could be just as confusing.

An alternative would be to display Add Alarm at the top if their are no existing alarms.  Also, All Alarms could be automatically forced to On if the last alarm is deleted.

Michael requested this bug for public discussion, but the deadline is tight!
Comment 1 Andy Grundman 2008-07-31 06:57:29 UTC
FWIW I sorta like having a quick way to turn off the alarms at the top of the list.  I also agree with Max that you may not know if alarms are turned off this way.
Comment 2 Michael Herger 2008-07-31 06:59:03 UTC
Adding alarms is a once in a while feature. Turning alarms on and off can be
every other day.

If it was possible to display the "Add" option first, as long as there's no
alarm, that would be reasonable. But once I've defined my alarms, I'd rather be
able to turn them off without much thinking, as I'll have to handle it at night
;-)
Comment 3 Blackketter Dean 2008-07-31 07:22:05 UTC
I'm good with having Add Alarm first only if there are no alarms set yet.

Comment 4 Max Spicer 2008-08-05 05:21:56 UTC
Change 22382 fixes this.  All Alarms On is now put at the bottom if there are no saved alarms.  When adding a new alarm, if (and only if) there are no other saved alarms, All Alarms is forced to On.

Forcing All Alarms to On doesn't currently work in the web ui.  This is because when you save an alarm from the web ui it also saves the displayed state of All Alarms, which overrides the internal, forced change.  The controller ui may have a similar issue, but I haven't tried it.
Comment 5 Max Spicer 2008-08-05 05:23:59 UTC
I was experimenting with renaming All Alarms On/Off to Alarm Clock On/Off in order to try and make it clearer that once you've set All Alarms to Off you won't see each alarm also set to Off.  I inadvertently included this change in the last commit, but only for the player ui.  If people are happy with this change, it should be mirrored in the web and controller.  Otherwise, it's simple to revert it.  No new strings were needed.
Comment 6 Michael Herger 2008-08-05 05:53:04 UTC
change 22383 - change the web settings handler to honor the enforced first alarm
Comment 7 Blackketter Dean 2008-08-05 07:25:06 UTC
All Alarms     On/Off

is clearer I think, let's leave it.
Comment 8 Max Spicer 2008-08-05 07:30:03 UTC
Back how it was in change 22386.
Comment 9 Michael Herger 2008-08-05 08:13:56 UTC
change 22389 - back in web UI, too

Though I'm not sure "All Alarms - On" really says what it does.
Comment 10 Max Spicer 2008-08-05 08:15:07 UTC
Indeed, and there have been several cases of users getting confused.
Comment 11 Max Spicer 2008-08-05 10:39:58 UTC
Remaining work on this (if any) needs doing in the web and possible controller ui.  See comment #4.
Comment 12 Michael Herger 2008-08-06 02:36:01 UTC
fixed in change 22383 (see comment #6 ;-)). Feel free to re-open if I missed on open issue.
Comment 13 Max Spicer 2008-08-06 02:38:14 UTC
Sorry, Michael - I missed that one!
Comment 14 James Richardson 2008-08-26 13:56:19 UTC
Verified fixed in
SqueezeCenter 7.2-22900
Comment 15 James Richardson 2008-12-15 11:59:01 UTC
This bug has been fixed in the latest release of SqueezeCenter!

Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already.  

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.