Bugzilla – Bug 8939
MP3 file with invalid id3v2 data causes the scanner to crash
Last modified: 2009-07-31 10:26:11 UTC
Customer has an MP3 file that causes the scanner to crash. File will play in iTunes and Windows media player without any problem. We checked the file tag using MediaMonkey, but there was nothing unusual about the tag. We tried the file on SC 7.0.1 and 7.1 we got same result, the scanner crashes everytime it attempts to scan this file.
Created attachment 3710 [details] File to test
is there a log clip that an be attached?
tag and rename shows no tags for this file. it seems that MP3::Info is seeking past the end of file while trying harder to find a valid header.
Created attachment 3729 [details] ScannerLog
Created attachment 3730 [details] server log
Unable to reproduce a "lockup" with 7.2, however the server did become unresponsive when scanning just this single file. As soon as the scan was done, the server was back to normal. Log Attached.
Can you reproduce with scan.scanner debug? I don't have any problems with this file, maybe it's a Windows-only issue? If the scanner actually crashes, what is the crash message? These logs look fine.
using formats.audio, plus a few warnings in MP3::Info for reference. After the second case of the warning on line 1603, perl interpreter crashes "encountered a problem and needs to close" dialog box. Warning at 1598 is $off, and at 1603 is $tot. C:\slim\boom\server>scanner.pl c:\music\bug8939.mp3 --debug formats.audio [08:57:47.2170] Slim::Formats::MP3::getTag (156) Trying to read ID3v2 tags from C:\music\bug8939.mp3 [08:57:47.2263] Slim::Formats::MP3::getTag (165) Didn't find any ID3v2 tags, trying v1 tags. [08:57:47.2274] MP3::Info::get_mp3info (1598) Warning: 503316498 at C:\slim\boom\server\lib/MP3/Info.pm line 1598, <$fh> line 1. [08:57:47.2279] MP3::Info::get_mp3info (1602) Warning: Warning: something's wrong at C:\slim\boom\server\lib/MP3/Info.pm line 1602, <$fh> line 1. [08:57:47.2283] MP3::Info::get_mp3info (1603) Warning: 503324690 at C:\slim\boom\server\lib/MP3/Info.pm line 1603, <$fh> line 1. 0[08:57:47.2288] MP3::Info::get_mp3info (1624) Warning: Warning: something's wrong at C:\slim\boom\server\lib/MP3/Info.pm line 1624, <$fh> line 1. [08:57:47.2294] Slim::Formats::MP3::getTag (189) Didn't find audio information in first pass - trying harder. [08:57:47.2301] MP3::Info::get_mp3info (1598) Warning: 503316498 at C:\slim\boom\server\lib/MP3/Info.pm line 1598, <$fh> line 2. [08:57:47.2306] MP3::Info::get_mp3info (1602) Warning: Warning: something's wrong at C:\slim\boom\server\lib/MP3/Info.pm line 1602, <$fh> line 2. [08:57:47.2311] MP3::Info::get_mp3info (1603) Warning: 503365650 at C:\slim\boom\server\lib/MP3/Info.pm line 1603, <$fh> line 2.
using winamp, i couldn't find any tags at all. winamp played it fine tho. i then used lametag to see if it had a lame tag header, and it doesn't. will SC play a mp3 if it has no lame tag at all?
Andy: See KDF's snipet
OK, it's a Windows-only issue, will try to fix.
Fixed in change 22482.
Verified, no scanner crash, 7.2.1 - 23530.
This bug has been fixed in the 7.3.0 release version of SqueezeCenter! Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already. If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.
Reduce number of active targets for SC