Bug 8813 – Music IP interface non-functional with new streaming nightly build

Bug 8813 - Music IP interface non-functional with new streaming nightly build

Summary:

Music IP interface non-functional with new streaming nightly build

Status:	RESOLVED FIXED

Product:	Logitech Media Server
Classification:	Unclassified
Component:	Player UI
Version:	unspecified
Platform:	PC Windows Vista

Importance:	-- normal (vote)
Target Milestone:	---
Assigned To:	Andy Grundman

URL:
Keywords:	new_streaming

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2008-07-20 06:50 UTC by Doug Williams
Modified:	2008-08-28 17:09 UTC (History)
CC List:	3 users (show)

See Also:
Category:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Doug Williams 2008-07-20 06:50:34 UTC

After upgrading to the new streaming build the interface to MusicIP doesn't appear to be functional at all.  Windows XP and Linux (by Michael).  No errors noted on the screen.  MusicIP Version: 1.8 GA release.  MIP and SC are on the same box.

Message in the server log file:
[08:45:15.6799] Slim::Plugin::MusicMagic::Plugin::initPlugin (152) Can't connect to port 10002 - MusicIP disabled.

However, I can connect to the 10002 port and get the MusicIP web page just fine.  From another computer, even.

Comment 1 Michael Herger 2008-07-20 13:11:22 UTC

New Slim::Player::Protocols::HTTP requires a song as parameter, but MIP is using the "url" instead.

--- HTTP.pm     2008-07-20 22:10:06.000000000 +0200
+++ /tmp/HTTP.pm        2008-07-20 22:09:51.000000000 +0200
@@ -31,7 +31,7 @@
        my $class = shift;
        my $args  = shift;

-       if (!$args->{'song'}) {
+       if (!($args->{'song'} || $args->{'url'})) {

                logWarning("No song passed!");
                return undef;


This does fix this issue for me, but I'm not sure about potential side-effects.

Comment 2 Andy Grundman 2008-07-20 13:21:12 UTC

I think MIP will need some changes instead to support the new API.  I'll look at it tomorrow.

Comment 3 Doug Williams 2008-07-23 05:32:49 UTC

With SC build 22008 the MIP integration appears to be working again.  I'll leave this open in case there is some behind the scenes work still being done one it, though.  Please let me know if there are some specific use cases that you would like tested.