Bug 8812 - Playlist editing a bit broken
: Playlist editing a bit broken
Status: NEW
Product: Logitech Media Server
Classification: Unclassified
Component: Web Interface
: 7.4.0
: PC Windows XP
: P4 normal (vote)
: 8.1.0
Assigned To: Michael Herger
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-07-20 06:48 UTC by Philip Meyer
Modified: 2009-07-29 06:18 UTC (History)
2 users (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Philip Meyer 2008-07-20 06:48:09 UTC
If I drag and drop in the playlist editor (default skin), upon dropping the item, that items' action buttons are left on the display (from the drag).

If I try to edit the path to an item that has changed, the item is removed from the playlist before the path can be edited.  The playlist is also updated/saved in the library (but not saved to disk), so there is a discrepancy.
Comment 1 Michael Herger 2008-07-20 13:04:59 UTC
What browser? Reproducible in a different browser? Cache cleared etc.? Do you see JS errors? Current playlist or stored playlist?
Comment 2 Michael Herger 2008-07-21 05:36:21 UTC
change 21952 - align current playlist and playlist editing
Comment 3 Michael Herger 2008-07-21 06:24:00 UTC
Oops, wrong bug.
Comment 4 Michael Herger 2008-07-21 07:00:38 UTC
change 21955 - hide controls during d'n'd
Comment 5 Michael Herger 2008-07-21 07:01:11 UTC
Argh... more oddities to fix. Sorry for the noise.
Comment 6 Michael Herger 2008-07-21 07:03:46 UTC
> If I try to edit the path to an item that has changed, the item is removed from
> the playlist before the path can be edited.

You mean that you see the item, but when you click "edit" it's being removed?


Comment 7 Chris Owens 2008-07-21 09:43:00 UTC
What behavior were you hoping for, Peter?  Clearly it's difficult to deal with tracks that aren't where we thought they were.  :)
Comment 8 Philip Meyer 2008-07-21 13:00:57 UTC
I see you've fixed the first part - action buttons are not left after a d'n'd any more.

>You mean that you see the item, but when you click "edit" it's being removed?
Yes.  I see a playlist item that I know points to a local file that I have renamed.  If I click to edit the item, it gets removed from the playlist, rather than allow me to edit it.

Also, at some point when I edited "Zapped Songs" as a test and saved the changes, it changed to "Zapped+Songs".  I guess that if I zap another song, this will create a new "Zapped Songs" playlist, so I'll have two playlists.  Probably need to unescape the + back to a space somewhere.
Comment 9 Michael Herger 2008-07-22 05:44:51 UTC
Don't know what to do with this. The items are disappearing due to the way SC is handling "disappearing" media. If it encounters a track which doesn't have a file on the disk any more, it's removed from the DB. Playlist editing goes through the same browsedb code.

Can't reproduce the "Zapped Songs" issue. Do you see this with any playlist with a space in its name?
Comment 10 Philip Meyer 2008-07-23 13:48:40 UTC
>Can't reproduce the "Zapped Songs" issue. Do you see this with any playlist
>with a space in its name?

Yes, I've just repeated this.

I had a playlist called "Testbed".  I clicked the edit icon.  On the playlist edit screen, I changed the playlist name to "Testbed Copy" and pressed save.

At this point, the playlist name remained displayed as "Testbed Copy".  However, I then change to a different player, when the edit playlist frame refreshes, the playlist changes to "Testbed+Copy".
Comment 11 Michael Herger 2008-07-23 15:09:41 UTC
Phil - what OS/browser are you using? Can you reproduce it with a different browser?
Comment 12 Philip Meyer 2008-07-23 17:13:31 UTC
FF3.

I just tried IE7, and the same thing happened.

Back to the other matter of playlist entries being deleted if they are not recognised as valid song urls.  Another issue I experienced tonight was that I created a playlist with an entry "wavin:1", which is used for the WaveInput plugin to read live soundcard output.

I seem to be able to enter that urn, and save the playlist.  But when I do a rescan, I get a warning that the item doesn't exist on disk, and therefore is removed from the playlist.
Comment 13 Michael Herger 2008-07-23 21:49:53 UTC
> FF3.
> I just tried IE7, and the same thing happened.

Server on XP then?

> Back to the other matter of playlist entries being deleted if they are not
> recognised as valid song urls.

Please file a new bug for this issue. Thanks!
Comment 14 Michael Herger 2008-07-24 05:06:28 UTC
I'm sorry, still can't reproduce the + issue. Tried SC running on OSX and Windows, FF3/Win, IE6, Opera/Mac, FF2/Mac - no problem. Tried Classic and Default. Anything else I should try? Are you using some security suite or browser extension which might install a proxy to protect you from whatever malware there is?
Comment 15 Philip Meyer 2008-07-25 15:38:12 UTC
I'm using AVG Antivirus, which has a Link Scanner and Anti Spyware modes.  I have Comodo Firewall Pro.

I don't think either of these are interracting though.

The exact repeatable steps that I have are:

1. Click on Home > Playlists > Zapped Songs.
2. Change playlist name to Zapped Songs2.
3. Click Save
4. Change player.

The playlist name has changed to Zapped+Songs2.

I can try using IE6 remotely from my work PC to access my home server, but not until tuesday.
Comment 16 Michael Herger 2008-07-28 01:47:16 UTC
> I'm using AVG Antivirus, which has a Link Scanner and Anti Spyware modes.  I
> have Comodo Firewall Pro.
> 
> I don't think either of these are interracting though.

Can you make sure they don't? Turn them off and try again. At least AVG might be acting as a proxy.
Comment 17 Philip Meyer 2008-07-28 02:23:19 UTC
I disabled AVG Link Scanner, and turned off firewall.  Didn't make any difference.

I've tried looking at the requests made when changing player.  There's a GET request for edit_playlist.html:

http://localhost:9000/Default/edit_playlist.html?newname=Trim%2Bme&submit=Save&playlist.id=21036&renamePlaylist=1&editPlaylist=0&deletePlaylist=0&addItem=0&player=00%3A04%3A20%3A1e%3A02%3A28
Comment 18 Michael Herger 2008-07-28 11:23:07 UTC
QA - can you reproduce the playlist name issue ("+" instead of space)?
Comment 19 James Richardson 2008-08-06 13:29:02 UTC
Unable to reproduce the error with 7.2-22374

Using the steps in Comment #15 work for me on OSX/Vista with Safari / FF / Opera / IE
Comment 20 Philip Meyer 2008-08-06 14:40:31 UTC
I forgot to check this from IE6 remotely from work - will try to check that tomorrow.
Comment 21 Philip Meyer 2008-08-07 06:29:26 UTC
I've tried this from a remote machine connecting to my server, using IE6.  The same fault happens.

Comment 22 Michael Herger 2008-08-07 06:50:39 UTC
now what's a "remote" vs. "local" browser? I doubt it makes a difference whether you access from localhost or not. I'd rather bet we're hitting another bug with IE6 :-(. Can you make sure IE6 is working properly when note using it remotely?
Comment 23 Philip Meyer 2008-08-07 11:30:03 UTC
>I doubt it makes a difference whether you access from localhost or not.
>I'd rather bet we're hitting another bug with IE6 :-(

The reason for testing remotely was purely so I could try it in IE6.  I'd already tried FF3 and IE7 from my home machine (same PC as the SC server).

All three browsers exhibit the same behaviour.
Comment 24 James Richardson 2008-08-08 09:57:30 UTC
bumping to 7.3
Comment 25 Ross Levine 2008-11-12 17:18:02 UTC
I've reproduced this using the steps in comment #15 with 7.3 and 7.2.1. By following those steps exactly I can reproduce this every time. I'm using IE6; Michael let me know if I can provide anything else to help. 
Comment 26 Michael Herger 2008-11-13 08:52:14 UTC
Ok, that's one more instance of the long standing issue "reloading a URL has unpredictable side-effects". We've been facing this ever since we've been using JS to dynamically switch players. This case is so particular, I'll punt it. We'll eventually have to get rid of the need to reload a document to change it's player context.
Comment 27 Michael Herger 2009-07-29 06:18:06 UTC
Punting skin related issues as the web UI should see another overhaul post 7.4.