Bugzilla – Bug 8776
Power off doesn't work when pressed between preset button and time it takes to initiate stream
Last modified: 2009-07-31 10:24:56 UTC
Thanks Dave for spotting this one. Stream music, press a preset button to play a favorite (I have it set to radio time streams) and before the stream starts playing hit the power button. Boom will come back on and stream despite your split-second change of mind.
unassigning to get more eyes on this
so, power button does actually work? If so, then the problem is the response to the buffer full event or the response from the remote server triggering playback. Sounds vaguely like the problem where random mix was also causing players to turn back on. Looks like a need for normalising the behaviour of powering off so that async events like this get cancelled.
(In reply to comment #2) > so, power button does actually work? Correct, it displays date/time then suddenly it's on and streaming.
Ross - do you still see this with the new streaming branch?
Andy notes this behavior has actually gotten worse with new streaming
Fixed in change 22279.
Hmm, I cannot reproduce this with new-streaming. Looking at the code, I think that it should already work correctly. If Song.pm is doing the async getTrackInfo stuff while Player::power() is invoked, then playing() will be true and, as it is a remote stream, 'stop' will be executed which will cancel the results of the async fetch. I guess that there could be a window caused by the deferred execution of the stop command, but it would be very small.
I'm still able to reproduce this in 7.2 - 22623. I'm using a station local here via Radio Time, it takes about 3 seconds to start playing after I hit the preset button. If I hit the preset button then the power button within that 3 seconds, I can reproduce this.
Still able to reproduce this with steps in comment #8.
With 7.3?
Sorry I should have been more clear, I'm able to reproduce with 7.2.1 - 23530.
Should already be fixed in 7.3
7.3 - 23752, this is actually a little bit worse. If you are playing some music, and you press a preset and immediately hit power the off screen saver shows but the music starts playing. From this state you can't pause or adjust volume you have to press power first.
Cannot reproduce in 7.3, works fine for me.
Oops, figures, now I do see it.
Alan: can you take a look? It seems it works as intended if you do this: 1. Player stopped and powered on. 2. Press preset assigned to slow-scanning radio station. 3. Power off. But the bug occurs if you do this: 1. Player playing a local track. 2. Press preset assigned to slow-scanning radio station. 3. Power off.
Change 23888
This bug has been fixed in the 7.3.0 release version of SqueezeCenter! Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already. If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.
Reduce number of active targets for SC