Bugzilla – Bug 8768
re-entering favorites menus results in a bogus menu item entry at bottom
Last modified: 2008-08-04 14:06:07 UTC
reported in the forums. I've reproduced this: - At any time, going to the favorites menu, clicking back, and then going to the favorites menu again will create a new menu item "function 0x1ae0c0" Mine to attempt a fix for 7.1
XMLBrowser is tacking on an empty hashref to the subItems array in cliQuery_done() each time I re-enter the Favorites menu in jive. Now if I could just figure out why... [10:34:56.5942] Data::Dump::dump (100) Warning: [ { icon => "html/images/artists.png", items => [], name => "3rd Bass", type => "audio", url => "db:contributor.namesearch=3rd Bass", value => "db:contributor.namesearch=3rd Bass", }, ] [10:34:56.5953] Slim::Buttons::XMLBrowser::_cliQuery_done (2224) COUNT! 1 [10:35:01.2042] Data::Dump::dump (100) Warning: [ { icon => "html/images/artists.png", items => [], name => "3rd Bass", type => "audio", url => "db:contributor.namesearch=3rd Bass", value => "db:contributor.namesearch=3rd Bass", }, {}, ] [10:35:01.2052] Slim::Buttons::XMLBrowser::_cliQuery_done (2224) COUNT! 2 [10:35:37.3238] Data::Dump::dump (100) Warning: [ { icon => "html/images/artists.png", items => [], name => "3rd Bass", type => "audio", url => "db:contributor.namesearch=3rd Bass", value => "db:contributor.namesearch=3rd Bass", }, {}, {}, ] [10:35:37.3257] Slim::Buttons::XMLBrowser::_cliQuery_done (2224) COUNT! 3
btw, this is definitely been tracked to XMLBrowser. The 'favorites items' cli query command is producing the same list of correct length each time.
Fixed in change 21841. $feed from Favorites is a persistent data structure so we need to send a copy of it to XMLBrowser.
Would it be better to fix xmlbrowser here? There is already a dclone going on in S:P:Favorites:Opml->xmlbrowser which attempts to keep the same hash until the cache time expires - the idea was we would keep subfeeds in the same hash to avoid redoing work. Seems to work for the web interface, so hopefully it can work for cli too? I'll look at it unless there was a more significant reason for doing this.
This bug has now been fixed in the 7.1 release version of SqueezeCenter! Please download the new version from http://www.slimdevices.com if you haven't already. If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.