Bug 8760 - Drag 'n' Drop reordering in Now Playing is incorrect
: Drag 'n' Drop reordering in Now Playing is incorrect
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Web Interface
: 7.2
: PC Windows XP
: P3 normal (vote)
: 7.x
Assigned To: Michael Herger
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-07-16 16:31 UTC by Philip Meyer
Modified: 2009-07-31 10:24 UTC (History)
0 users

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Philip Meyer 2008-07-16 16:31:55 UTC
In the default skin, if I drag a song downwards in the now playing list, it sometimes gets moved one track further down the list than the insertion line indicated.

Sometimes a second or so later, the list is then refreshed again and the song is then in the right position, but not always.
Comment 1 Michael Herger 2008-07-17 01:41:21 UTC
I hate "sometimes" and "not always" bugs :-). Do you have additional information like eg. multi page playlist or not, after consecutive d'n'd actions or not, when dragging from above to below the currently playing song etc.?
Comment 2 Philip Meyer 2008-07-17 04:29:42 UTC
Not a multiple-page playlist.

I've just repeated it.  I had a playlist of 31 songs. I am displaying with show artwork enabled.

I dragged the last item upwards.  I hovered above the 27th item.  When the mouse is in the top-half of the 27th item, the insertion line is above the 27th item.  When I moved the mouse down a little more (just below half way down the 27th item, the insertion line moves below that item.  However, when I drop the item, it still goes above the 27th item.
Comment 3 Michael Herger 2008-07-17 08:34:39 UTC
change 21828 - when dropping a playlist element, not only adjust the position offset, but the target element, too. Please clear the cache etc. :-)
Comment 4 Philip Meyer 2008-07-21 12:45:14 UTC
Seems to work most of the time when I drag items from the bottom upwards (once it didn't seem to move the item when I dropped it directly on top of another item).

However, it doesn't work if I drag the first item in the list downwards.

I notice the same effect when editing playlists too.
Comment 5 Michael Herger 2008-07-22 05:09:53 UTC
working fine for me. Are you still talking about the Now Playing playlist? Or editing a saved playlist?
Comment 6 Philip Meyer 2008-07-22 16:53:21 UTC
>Are you still talking about the Now Playing playlist? Or editing a saved >playlist?
Both.

I pick the top item in the list, drag it over the third item in the list, such that the line is between 2nd and 3rd items.  When I release, nothing happens.  If I drop when mouse is over bottom half of 3rd item (line is between 3rd and 4th items), it works.
Comment 7 Michael Herger 2008-07-23 03:45:20 UTC
change 22006 - don't compare source/target position, but the position indicator telling whether item has to be inserted before or after the target element.

Thanks for testing! Could you please once more?...
Comment 8 Philip Meyer 2008-07-23 13:42:26 UTC
Seems to be working fine now - thanks.

One minor thing though - the mouse pointer image changes according to what the mouse is hovering over, instead of always being a move icon when dragging.
Comment 9 Michael Herger 2008-07-24 02:58:19 UTC
Phil - please submit a separate bug for the mouse cursor. Don't know whether I'll be able to fix it, though. Seems to be buried somewhere in the ExtJS toolkit :-/. But I'd like to close this bug, as reordering is fine now. Thanks.
Comment 10 Chris Owens 2008-07-30 15:31:35 UTC
This bug has now been fixed in the 7.1 release version of SqueezeCenter!  Please download the new version from http://www.slimdevices.com if you haven't already.  

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.
Comment 11 Chris Owens 2009-07-31 10:24:53 UTC
Reduce number of active targets for SC