Bugzilla – Bug 8751
MusicIP mix not available from album page in default/fishbone skin
Last modified: 2009-07-31 10:24:52 UTC
In the default skin mixer icons is supposed to be shown in the page header in default/fishbone skins when you have selected an album. So on the right side of the play/add buttons mixer icons should appear. This doesn't work for MusicIP mixes, its mix icons never appear in this place. The mix icons are shown on the previous page when listing albums and it is shown in the album page for all tracks, but it isn't shown in the header of the album page. Some detailed information from my own investigation: ========================= The Slim::Plugin::MusicMagic::Plugin::mixerlink function is called correctly and sets the mixermagic_mixable value in the $form correctly. In the album page it is called once for each track in the album and at last also one time for the album object itself. The problem is that the $form doesn't seem to be forwarded correctly to for the album to plugins/MusicMagic/mixerlink.html for the album object. The mixerlink.html is processed for the album, but it doesn't get the form as the "item" parameter and due to this it doesn't show the mixer buttons in the header. I'm not completely sure but I think the problem might be when songinfo_header.html is called with PROCESS in HTML/Default/browsedb.html, it should probably needs to somehow pass the $form parameter besides the parameters it passes already now.
Created attachment 3591 [details] working for me
Created attachment 3592 [details] fishbone too
Please make sure you've got the latest code as I've changed this bit yesterday.
Created attachment 3595 [details] Patch to solve the problem The problem is if you have several mixers, so I think it works as long as you only have the MusicIP mixer. But if you for example install the TrackStat plugin it will no longer be displayed. I had the problem with the latest svn version. This patch should solve the problem.
Will have to test with an additional mixer.
Just to be sure: should there be a TS icon on the track page too?
change 21820 - thanks!
This bug has now been fixed in the 7.1 release version of SqueezeCenter! Please download the new version from http://www.slimdevices.com if you haven't already. If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.
Reduce number of active targets for SC