Bug 8719 – no window animation when pressing home in NowPlaying screensaver

Bug 8719 - no window animation when pressing home in NowPlaying screensaver

Summary:

no window animation when pressing home in NowPlaying screensaver

Status:	CLOSED FIXED

Product:	SB Controller
Classification:	Unclassified
Component:	Screensavers
Version:	unspecified
Platform:	PC Other

Importance:	-- normal (vote)
Target Milestone:	7.1
Assigned To:	Ben Klaas

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2008-07-13 09:07 UTC by Ben Klaas
Modified:	2008-12-15 12:38 UTC (History)
CC List:	1 user (show)

See Also:
Category:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Ben Klaas 2008-07-13 09:07:18 UTC

Found by Fletch and reported in forums. I've reproduced this as well:

2) If I press home from the NPSS, it goes home but does not use the usual "sliding window" animation (or whatever it's called).  It just switches over to the home page.

Comment 1 Ben Klaas 2008-07-14 15:22:10 UTC

fixed in r2696

Comment 2 Mark Miksis 2008-07-17 10:18:41 UTC

Ben,

I noticed that with this fix, there is still no animation if the SBC is on the home screen prior to the NPSS activating and I then press home.  Is this expected?

Comment 3 Ben Klaas 2008-07-17 11:11:36 UTC

hmmm..interesting (and fully reproduced).

I'm not sure if the animation should be there, actually. What you are doing in essence in this special case is hitting the home key to view the underlying window, which is home. Should that have an animation? Not sure...

fwiw, the reason there's no animation is that the Slimbrowser.goHome() method doesn't have any windows to hide (except for the screensaver window itself, which gets hidden without a transition, which IMO is correct behavior).

-- goHome
-- pushes the home window to the top
function goHome()
        local windowStack = Framework.windowStack
        Framework:playSound("JUMP")
        while #windowStack > 1 do
                windowStack[#windowStack - 1]:hide()
        end
end

In the case of already being home, #windowStack == 1, therefore no window:hide() methods are called, thus no transition animation.

Comment 4 Mark Miksis 2008-07-17 11:20:19 UTC

Yeah, I figured it was something like that which is why I asked if it was expected.

Anyway, IMO it's not a big deal, but it is noticeably "different".  I just wanted to make sure you were aware...

Comment 5 Chris Owens 2008-07-30 15:29:30 UTC

This bug has now been fixed in the 7.1 release version of SqueezeCenter!  Please download the new version from http://www.slimdevices.com if you haven't already.  

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.

Comment 6 James Richardson 2008-12-15 12:38:44 UTC

This bug has been fixed in the 7.3.0 release version of SqueezeCenter!

Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already.  

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.