Bug 8707 - the reconnect code rdoesn't handle the case where the disconnects happens *after* the reconnect
: the reconnect code rdoesn't handle the case where the disconnects happens *af...
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Controller
: 7.1
: PC Other
: P1 critical (vote)
: 7.x
Assigned To: Andy Grundman
:
Depends on:
Blocks: 5378
  Show dependency treegraph
 
Reported: 2008-07-11 15:04 UTC by Richard Titmuss
Modified: 2009-07-31 10:24 UTC (History)
0 users

See Also:
Category: ---


Attachments
Log file (131.54 KB, application/rtf)
2008-07-11 15:04 UTC, Richard Titmuss
Details
Patch (1.09 KB, patch)
2008-07-12 09:32 UTC, Andy Grundman
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Richard Titmuss 2008-07-11 15:04:18 UTC
Created attachment 3566 [details]
Log file

From campfire:


Andy G.  	
Richard: ok so you can see the server lost the connection to jive before it had the Rhapsody response

Richard T. 	
but is it not an earlier connection that's lost?
Jul 11 	
2:30 PM
Richard T. 	
i assume this is where you say the connection is lost:
Richard T. 	
View paste

[21:51:52.5456] Slim::Web::HTTP::processHTTP (368) Client at 192.168.1.73: disconnected. (sysread: Connection reset by peer)
[21:51:52.5460] Slim::Web::HTTP::closeHTTPSocket (2519) Closing HTTP socket Slim::Web::HTTP::ClientConn=GLOB(0x57b4ad0) with 192.168.1.73:0 (sysread: Connection reset by peer)

Richard T. 	
but the reconnect is on this connection:
Richard T. 	
View paste

[21:51:50.8676] Slim::Web::HTTP::processHTTP (377) HTTP request: from 192.168.1.73:39410 (Slim::Web::HTTP::ClientConn=GLOB(0x5721b50)) for POST HTTP/1.1 /cometd

Andy G. 	
oh hmm

Richard T. 	
looking back in the terminal, the connection that's closed was last mentioned:
Richard T. 	
View paste

[20:35:05.5811] Slim::Web::HTTP::processHTTP (377) HTTP request: from 192.168.1.73:44110 (Slim::Web::HTTP::ClientConn=GLOB(0x57b4ad0)) for POST HTTP/1.1 /cometd

Richard T. 	
so somehow SC is not noticing that connection has closed until after the new one is established.
Jul 11 	
2:35 PM
Andy G. 	
ok yep
Andy G. 	
the reconnect code removes the disconnect timer, but doesn't handle the case where the disconnects happens *after* the reconnect
Jul 11 	
2:40 PM
Andy G. 	
I wonder why the disconnect debug line doesn't show the port number
Comment 1 Andy Grundman 2008-07-12 09:32:39 UTC
Created attachment 3572 [details]
Patch

I'd check this patch in but svn is down right now.
Comment 2 Andy Grundman 2008-07-12 10:26:45 UTC
Fixed in 7.1 change 21670.
Comment 3 Chris Owens 2008-07-30 15:27:54 UTC
This bug has now been fixed in the 7.1 release version of SqueezeCenter!  Please download the new version from http://www.slimdevices.com if you haven't already.  

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.
Comment 4 Chris Owens 2009-07-31 10:24:39 UTC
Reduce number of active targets for SC