Bug 8704 - Seek: FFWD/REW scanner UI timer doesn't reset with each button press
: Seek: FFWD/REW scanner UI timer doesn't reset with each button press
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Player UI
: 7.1
: All All
: P3 normal with 1 vote (vote)
: 7.x
Assigned To: Andy Grundman
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-07-11 11:12 UTC by Bruno Fernandes
Modified: 2009-07-31 10:24 UTC (History)
4 users (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Bruno Fernandes 2008-07-11 11:12:11 UTC
This issue is regarding the timing function used to remove the progress bar UI and return the player to Now Playing after a forward or rewind operation.

The progress bar that appears when using the new FFWD/REW commands has a fixed timeout duration that does not reset when subsequent presses of FFWD/REW are made. This can cause the Now Playing display to return while a customer is in mid FFWD or REW.

A more intuitive behavior for this type of control is to provide a reseting timer - triggered by RELEASING either FFWD or REW.

UI functional Flow:

1. Press either FFWD/REW - causes seek/scanner progress UI to appear immediately. 
2. While continuing to press FFWD/REW - seek/scanner progress UI stays up.
3. Release FFWD/REW (player no longer receiving either command) - start timer.
4. Press FFWD/REW again before timer expires - timer resets & stops. Back to situation #2
5. Timer expires - causes Now Playing info display to return.

I also propose the timer be shortened as right now it seems far too long, which may have been done on purpose because it doesn't reset with each FFWD/REW press.  10 seconds is probably a good interval, though making this some type of deep pref might be a good idea.
Comment 1 Bruno Fernandes 2008-07-11 11:13:37 UTC
Last tested with:

SqueezeCenter Version: 7.1 - 21576 @ Tue Jul 8 01:04:57 PDT 2008 - Windows XP - EN - cp1252

Squeezebox v3, Firmware v.97
Comment 2 Bruno Fernandes 2008-07-11 15:43:49 UTC
Steps to reproduce issue (sorry forgot this last time)

1. Start a track of at least 3 or 4 minutes (to allow seeking without hitting the end of the track quickly)
2. Just after track starts, press and hold FFWD on remote
3. Wait while watching the progress bar move toward the end of the track - don't let it reach the end
4. Before hitting the end, press and hold REW
5. Wait while watching the progress bar move toward the start of the track - don't let it reach the start
6. Repeat steps 2-5
7. Note that at some point the progress bar will suddenly disappear and your FFWD/REW operation will stop.

The duration of time before the progress bar disappears is the same regardless of whether or not you're pressing the FFWD/REW buttons.

Comment 3 Chris Owens 2008-07-14 10:07:39 UTC
Triode, Alan suggests that some change you recently made may have had an effect on this.  Does it ring a bell?
Comment 4 Adrian Smith 2008-07-14 13:08:14 UTC
I believe change 21744 fixes this - please works for you.
Comment 5 Chris Owens 2008-07-28 10:39:44 UTC
Bruno, has this fixed the behavior you were seeing?

QA also to verify the fix.
Comment 6 Bruno Fernandes 2008-07-29 14:34:15 UTC
The problem is still present.

I have tested with:
SqueezeCenter Version: 7.1 - 21854 @ Fri Jul 18 01:03:55 PDT 2008 - Windows XP - EN - cp1252
Which was built after the change previously mentioned.  

I will provide even more specific steps to reproduce below because I realize the steps I previously provided can be performed in two similar, but different ways.

Method one - switching between FFWD/REW fast enough that the play point does not change.
Method two - allowing the song to start playing from the new point before pressing FFWD/REW again.

Method one no longer causes the problem. Method two still does.

New steps to reproduce:

1. Start a track of at least 3 or 4 minutes (to allow seeking without hitting
the end of the track quickly)
2. Just after track starts, press and hold FFWD on remote
3. Wait while watching the progress bar move toward the end of the track -
don't let it reach the end
4. Before hitting the end, release the button and let the track start playing from the new point
5. Quickly press and hold REW
6. Wait while watching the progress bar move toward the start of the track -
don't let it reach the start
7. Before hitting the start, release the button and let the track start playing from the new point
8. Repeat steps 2-7
9. Note that at some point the progress bar will suddenly disappear and your
FFWD/REW operation will stop.

Comment 7 James Richardson 2008-07-31 09:32:49 UTC
Alan: Can you have a look at this, and target appropriately.
Comment 8 Andy Grundman 2008-08-01 06:00:23 UTC
Bruno, I'm not sure you were able to test the fix Triode made in change 21744.  Please retest with tonight's 7.2 nightly and reopen if this is still an issue.  Change 22290.
Comment 9 Spies Steven 2008-08-26 15:10:50 UTC
Verified with SC 7.2 - 22900
Comment 10 James Richardson 2008-12-15 12:34:11 UTC
This bug has been fixed in the 7.3.0 release version of SqueezeCenter!

Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already.  

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.
Comment 11 Adrian Smith 2008-12-30 10:50:49 UTC
Bruno was correct - there were still cases when this occured.  Hopefully these are fixed by change 24436.
Comment 12 Chris Owens 2009-07-31 10:24:38 UTC
Reduce number of active targets for SC