Bug 8701 - Need a Line In plugin to allow users to use the line in when connected
: Need a Line In plugin to allow users to use the line in when connected
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Player UI
: unspecified
: PC Other
: -- normal (vote)
: ---
Assigned To: Michael Herger
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-07-11 04:30 UTC by Blackketter Dean
Modified: 2008-12-15 11:58 UTC (History)
5 users (show)

See Also:
Category: ---


Attachments
Icon proposal: 1 (39.19 KB, image/png)
2008-07-25 16:27 UTC, ndijulio
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Blackketter Dean 2008-07-11 04:30:06 UTC
This should be an updated version of Digital Input that shows Line In on boom as a home menu choice when there's something plugged into the jack.

Otherwise, it should be hidden.

(Noah:  We'll need a "line in" icon as well.  A stylized 3.5mm plug is probably a good graphic to use.)

This plugin should also work on SN.
Comment 1 KDF 2008-07-11 10:21:36 UTC
digital input plugin doesn't currently work at all with SN, correct?  So, if line-in needs to work through SN, we'd need to write it not as a plugin (perhaps under settings->audio?)

What is the slimproto command for enabling line in?
Comment 2 KDF 2008-07-11 10:22:04 UTC
oh, also need the status info to know when something is plugged in.
Comment 3 Andy Grundman 2008-07-11 10:31:24 UTC
Digital Input works fine on SN. :)
Comment 4 Chris Owens 2008-07-21 10:35:12 UTC
cc'ing Caleb so he can talk about some of the features he has in mind.

Andy asks if the slimproto command has been implemented yet, and Felix says 'no' so that needs to get done first, then assign to Michael for the plugin.
Comment 5 Felix Mueller 2008-07-22 07:33:28 UTC
I lied. ;) The slimproto command 'audp' (same as for TR) is already in place to set 'line in' as source in Boom.

Use '1' to turn 'line in' on and '0' to turn it off.

What's still missing in firmware is a notification for SC when something gets plugged into the jack so line in can be selected automatically.
Comment 6 Michael Herger 2008-07-22 07:38:07 UTC
Felix - what do you want me to do?
Comment 7 Felix Mueller 2008-07-22 07:43:39 UTC
Michael - Well, you could start implementing the 'Line In' plugin, similar to TRs 'Digital Input' plugin.
Comment 8 ndijulio 2008-07-23 15:58:53 UTC
What is the deadline for the Line-In icon artwork?
Comment 9 Blackketter Dean 2008-07-23 16:07:16 UTC
Very soon.  We're trying to finish this up in the next few days.
Comment 10 ndijulio 2008-07-23 16:19:20 UTC
Would by Friday, the 25th work?
Comment 11 Felix Mueller 2008-07-24 02:07:04 UTC
Boom firmware now reports the status of 'line in' and 'line out' (i.e. whether something is plugged into the jack) in the slimproto STAT event.

I've reused the 'voltage' field (which was only used for TR so far).

0 : nothing is plugged into either jack
1 : something is plugged into 'line in' jack
2 : something is plugged into 'line out' jack
3 : something is plugged into both jacks

This change is in Boom fw 19.
Comment 12 Michael Herger 2008-07-24 02:18:36 UTC
Felix - could you please provide ten lines of code to show me how you do the switching?
Comment 13 Felix Mueller 2008-07-24 02:37:07 UTC
I think there are two parts to it, some is handled in the Digital Input plugin, which sets a special URL and the second part, the switching actually is done in Tranporter.pm setDigitalInput().

I suggest making a copy of DigitalInput plugin, reducing it to one input and using whatever is needed from Transporter.pm and copy it into Boom.pm.

And to answer your question about how to switch, something like that:

$client->sendFrame('audp', \pack('C', $input));

where $input is '1' to turn it on and '0' to turn it off.
Comment 14 Felix Mueller 2008-07-24 02:45:46 UTC
I'll try to put a prototype together today for Michael to iron out.
Comment 15 Felix Mueller 2008-07-24 06:27:53 UTC
Working LineIn prototype added to SC boom branch. Quickly tested on SC, Boom and SBC.

At a minimum the correct icon needs to be added, maybe more.
Comment 16 Michael Herger 2008-07-25 05:36:52 UTC
change 22118 - simplified web and player UI for Line In
Comment 17 ndijulio 2008-07-25 16:27:47 UTC
Created attachment 3684 [details]
Icon proposal: 1

Attached artwork needs to be approved.
Comment 18 Blackketter Dean 2008-07-26 05:35:45 UTC
Works for me!  Approved.
Comment 19 Michael Herger 2008-07-27 13:26:34 UTC
change 22141 - update icon.

Feel free to re-open if the plugin doesn't what you wanted it to do.
Comment 20 Spies Steven 2008-08-26 14:54:15 UTC
Verified with SC 7.2 - 22900
Comment 21 James Richardson 2008-12-15 11:58:55 UTC
This bug has been fixed in the latest release of SqueezeCenter!

Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already.  

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.