Bugzilla – Bug 8682
Transcode error with Latin Punctuation
Last modified: 2009-07-31 10:24:29 UTC
See thread http://forums.slimdevices.com/showthread.php?t=49653 for everything I've done to isolate the problem.
https://bugs-archive.lyrion.org/page.cgi?id=fields.html#bug_severity please attach a clip from the server log, with player.source set to DEBUG, when trying to play.
Created attachment 3551 [details] Server log as requested
Created attachment 3552 [details] updated server log Thanks guys!! Let me know what else I can do.
UPDATE. I reverted SqueezeCenter back to v7.0, and all transcoding works as it should.
could you post the player.source log with the working install, trying to play the same songs? From the logs so far, it looks either alac is unable to read the file or unable to produce output for the stream.
Created attachment 3558 [details] server log (edited with new working info) Server log from SC v7.0 working.
Comment on attachment 3558 [details] server log (edited with new working info) Notice 9:09:21.3995 is an ALAC file converted to MP3 without the punctuation (Al Jarreau). 9:10:01.0195 is ALAC converted WITH punctuation (Alex Acüna) and 9:10:58.2764 is ALAC converted with punctuation (Albéniz). All files stream to my office SB3 as before the upgrade to official 7.01.
Michael says he has some thoughts about what this might.
Very likely related to bug 8118. Eric - would the transcoding work if you removed the conditional decoding of the file name to make it unconditional: Index: /Users/mh/Documents/workspace/unstable/server/Slim/Player/TranscodingHelper.pm =================================================================== --- /Users/mh/Documents/workspace/unstable/server/Slim/Player/TranscodingHelper.pm (revision 21761) +++ /Users/mh/Documents/workspace/unstable/server/Slim/Player/TranscodingHelper.pm (working copy) @@ -356,9 +356,9 @@ } else { # Bug 8118, only decode if filename can't be found - if ( !-e $filepath ) { +# if ( !-e $filepath ) { $filepath = Slim::Utils::Unicode::utf8decode_locale($filepath); - } +# } } } Andy - I remember the change that lead to bug 8118. I did it, as it fixed bug 7963 without breaking SC on OSX (which I tested with). 8118 reverted that change, which broke OSX again, but went unseen as testing probably was done on Linux/Windows only. This bug is actually a dupe of bug 7963. I wonder wether we should unconditionally decode on OSX.
Michael, I don't understand what you're asking. If I play the 'bad' file on my SB3 or TP at home with unlimited bandwidth, there isn't a problem as transcoding using LAME doesn't need to happen. How would I make it 'unconditional'? Are you meaning transcode at all times? I have tried that by bandwidth limiting the TP and the file won't play. Explain a little further what you're asking for. Thanks
Eric - I'm sorry for that. I was just assuming that you'were comfortable editing source files. Please don't hesitate telling me if you're not. What I wanted you to test was applying the above patch: by adding # in front of the if statement, filenames would always be decoded, not only if SC thought the file wasn't available. That's what I meant by making the decoding "unconditional". Some background information: the issue we're seeing is that the filename passed to flac/lame/alac is utf8 encoded. Those helper applications don't like this. Thus we need to decode the filename before passing it to the helper. The condition which prevents this decoding is checking from SC's point of view whether the file does exist or not. SC thinks it's fine, while the helper doesn't agree.
Yeah, I've got BBEdit, a text editor, that I used to use when I was writing HTML the hard way! As I had mentioned elsewhere, I do believe the problem is with LAME as we've discovered punctuation issues within other conversion programs using it as an encoder. What file am I looking at for this? I'll try getting to it this evening PDT .
It's very likely /Library/PreferencePanes/SqueezeCenter.prefPane/Contents/server/Slim/Player/TranscodingHelper.pm Please note that this is inside a preference pane. If you want to open it from Finder, then you'll have to open the context menu on /Library/PreferencePanes/SqueezeCenter.prefPane to open its package.
Great. Yeah I've climbed into packages before. Maybe I'll try this now since I can access my home system from work remotely. This would also prove if it works since I have the SB3 here that needs the MP3 transcoding. I'll get back to you later... thanks!
change 21785 - always utf8decode filenames on OSX Eric - if you don't feel like poking around your installation, you can give tomorrow's 7.1 build a try. Please let us know whether this fixes your issues. QA - please check for regression on bug 8118 (Linux & Windows). Thanks!
I pasted in this over the existing: # Bug 8118, only decode if filename can't be found - if ( !-e $filepath ) { +# if ( !-e $filepath ) { $filepath = Slim::Utils::Unicode::utf8decode_locale($filepath); - } +# } } } and now SC won't boot up. I hit the START button on the pref pane and it stops after a few seconds. Was this NOT what you wanted me to insert?
> I pasted in this over the existing: Don't know exactly what you mean by this, but I guess that wasn't any good... You do have a backup, don't you? :-/. You should hast have removed the lines marked with a "-" and added those with the "+". (Or - remove them only, without replacing anything, as the new lines are comments).
Right, so ALL those lines should be comments, or only the two you noted? I did do it with just the two and it still didn't start. I did a new install of the 7.1 nightly I had. I'll try it again but make a backup of the file first.
Created attachment 3590 [details] Log after HELPER change
I cut the lines of code instead of making them comments and it's good. It even played the files with transcoding. Let me know if you need the entire log. Thanks again, guys!
So it's finally working for you? Great news! The change I've checked in earlier today should do the same (though only on OSX). Please give the next nightly build a try and re-open this bug if it doesn't work for you. Thanks!
Thanks, Michael. Are you in the Mtn. View office? I'm going to be in Santa Clara tomorrow meeting with the company that's building our HDTV Remote Truck. I just Googled it and Slim is 7.2 miles up the 101 from where I'll be. If I can get a break, I'd love to stop in to see the 'mother ship'. Thanks again... you guys are awesome!
Eric: please retest with SqueezeCenter 7.1-21796. if you still see the error, then reopen the bug with added comments.
Verified it DOES work. Thanks!!
This bug has now been fixed in the 7.1 release version of SqueezeCenter! Please download the new version from http://www.slimdevices.com if you haven't already. If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.
Chris, thanks for the note about the fix. I had been contacted during beta and confirmed the fix then. Keep up the great work on this awesome product!!! Eric
This bug has been fixed in the 7.3.0 release version of SqueezeCenter! Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already. If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.
Reduce number of active targets for SC