Bug 8679 - Update strings for Fixed Digital Volume
: Update strings for Fixed Digital Volume
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Web Interface
: 7.1
: PC Other
: P1 critical (vote)
: 7.x
Assigned To: Michael Herger
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-07-08 16:12 UTC by Andy Grundman
Modified: 2009-07-31 10:24 UTC (History)
4 users (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Grundman 2008-07-08 16:12:51 UTC
Fixed digital volume now affects analog too, so the wording needs to be updated.
Comment 1 sbjaerum 2008-07-09 02:15:53 UTC
I haven't upgraded to latest firmware yet, so haven't tested.
But this concerns me a bit.
Will the fixed digital out option also fix the analog out level, resulting in a disabled volume control?
Will the analog out be fixed at max volume?
If so, will all users with fixed digital out option enabled but using analog out get playback at max volume after the firmware upgrade?
Comment 2 Sean Adams 2008-07-09 06:35:43 UTC
The ability to fix the digital levels and then listen to the analog output at varying levels was decided to be a corner case that we didn't need to support. It's just not that useful, and it had to be dropped in order to add the other new features in fw40+. (It effectively halves the data rate transmitted by the CPU, saving some cycles and doubling the maximum output sample rate.)

However, if somebody were using the product that way, then yes, their analog volume would become fixed upon upgrading. If we want to prevent that then upon upgrading from a <40 version, SC should disable the fixed feature and if it had been set, also lower the volume to -50dB. This would mean that the other users who do want the levels to be fixed would have to go in and turn on the setting again. 

That should go in a separate bug though - this one concerns just the incorrect description of the feature. 
Comment 3 Chris Owens 2008-07-16 17:45:08 UTC
If this is just a question of wording, does it need to be assigned to Dean?  Is he the one that comes up with wording?  Do we have time to get this translated for 7.1?

Unfortunately it seems like the clearest way to fix the strings are to change them to something like 'Player volume control' with options of 'Player volume control fixed at 100%' and 'Player volume control adjustable'
Comment 4 Blackketter Dean 2008-07-17 06:57:02 UTC
How about:

Adjustable Volume

vs.

Volume Fixed at 100%

With some support text:

You can fix the volume control at 100% if you are using the volume control on your amplifier to control loudness or need perfect digital passthrough. 

Brian:  Please review.

------------------------------

What happens in this case if the user try's to adjust the volume?  Do they get feedback on a volume level that no longer works?  That would be bad and another but should be opened.  The controls should be missing (web UI) and the buttons should have no effect.

Also, this control should be unavailable on devices without digital output.

Do we have time for a translation pass?
Comment 5 Michael Herger 2008-07-17 07:25:00 UTC
> How about:

Shall I implement this change?

> Do we have time for a translation pass?

Count 1-2 weeks at least - depends on our schedule.
Comment 6 Michael Herger 2008-07-17 10:28:46 UTC
So here's what I've checked in at change 21832:

SETUP_DIGITALVOLUMECONTROL_ON
	DE	Lautstärkeregelung über Fernbedienung
	EN	Volume controls adjust outputs
	FR	Niveau contrôlé par boutons de volume

SETUP_DIGITALVOLUMECONTROL_OFF
	DE	Lautstärke ist fixiert auf Maximum
	EN	Output level is fixed at 100%
	FR	Niveau sortie fixe à 100%

SETUP_DIGITALVOLUMECONTROL
	DE	Lautstärkeregelung
	EN	Volume Control
	FR	Niveau sortie

SETUP_DIGITALVOLUMECONTROL_DESC
	EN	You can fix the volume control at 100% if you are using the volume control on your amplifier to control loudness or need perfect digital passthrough. This affects both digital and analog volume.

Please review - thanks!
Comment 7 Michael Herger 2008-07-21 11:01:16 UTC
what's left to do for this bug?
Comment 8 Michael Herger 2008-07-23 22:20:26 UTC
Then I'll assume this is fixed.
Comment 9 Brian Dils 2008-07-25 19:31:22 UTC
Hopefully this isn't coming too late...I have some interaction suggestions that I just thought of.

The text sounds fine to me.  As far as the interactions go: if the volume is fixed, we should gray out the volume buttons on the web ui, not remove them. Maybe overlayed on the volume is messaging that says "Volume fixed on this player/device" then a link that says "undo"...I'll work on a mockup
Comment 10 Chris Owens 2008-07-30 15:31:31 UTC
This bug has now been fixed in the 7.1 release version of SqueezeCenter!  Please download the new version from http://www.slimdevices.com if you haven't already.  

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.
Comment 11 Chris Owens 2009-07-31 10:24:27 UTC
Reduce number of active targets for SC