Bug 8613 - character menu differs between Controller & Boom
: character menu differs between Controller & Boom
Status: CLOSED FIXED
Product: SB Controller
Classification: Unclassified
Component: UI
: unspecified
: All All
: -- normal (vote)
: 7.2
Assigned To: Michael Herger
:
Depends on:
Blocks: 9172
  Show dependency treegraph
 
Reported: 2008-06-30 14:45 UTC by Matthew J. Martin
Modified: 2009-09-08 09:28 UTC (History)
2 users (show)

See Also:
Category: ---


Attachments
patch to make sure JIVE_ALLOWEDCHAR* tokens have a prepended space (473 bytes, patch)
2008-07-01 08:50 UTC, Ben Klaas
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew J. Martin 2008-06-30 14:45:04 UTC
The character menu is ordered differently between SBController & Boom -- notably the position of the space character.
Comment 1 Blackketter Dean 2008-06-30 15:15:28 UTC
Richard: was this done on purpose...
Comment 2 Richard Titmuss 2008-07-01 00:26:25 UTC
No, I think it keeps getting foobared during the language translation. It should be the same as on the player.

Ben and/or Michael need to fix this.
Comment 3 Ben Klaas 2008-07-01 07:22:22 UTC
The problem is that if we put the space character at the end or at the start of the charset, the SLT team returns it without the space. Thus, I stuck it in the middle, between the lower a-z and upper A-Z chars.

I can change it back, but it will only result in SLT munging it again.

Could we change the boom char menu instead?
Comment 4 Blackketter Dean 2008-07-01 07:33:09 UTC
How about appending/prepending the space character programmatically rather than relying on it being in the string
Comment 5 Ben Klaas 2008-07-01 07:38:23 UTC
I could do that, though it would eliminate the possibility (well, without another hack) of using a charset that doesn't allow a space character, which seems like an plausible possibility.

Comment 6 Richard Titmuss 2008-07-01 08:05:02 UTC
it should be put back, and the scripts that process the output from SLT should verify the space is in the correct place for that token, and if not automatically correct it.

Comment 7 Ben Klaas 2008-07-01 08:37:40 UTC
space added back to the start of the charsets, 7.1 change 21373

I'm going to take a quick look at the SLT scripts and see what I can do to add a hack fix for those two tokens and ensuring a prepended space char on the sets.
Comment 8 Ben Klaas 2008-07-01 08:50:22 UTC
Created attachment 3518 [details]
patch to make sure JIVE_ALLOWEDCHAR* tokens have a prepended space

Michael, I think this will do it but as I don't have any way of testing, I'll just post this as a patch for you to look over and try.
Comment 9 Michael Herger 2008-07-04 02:11:04 UTC
thanks Ben. I'll test this after my vacation. Taking off the 7.1 radar.
Comment 10 Michael Herger 2008-07-24 02:24:00 UTC
Thanks Ben - change 22050
Comment 11 James Richardson 2008-12-15 12:39:51 UTC
This bug has been fixed in the 7.3.0 release version of SqueezeCenter!

Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already.  

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.