Bugzilla – Bug 8613
character menu differs between Controller & Boom
Last modified: 2009-09-08 09:28:28 UTC
The character menu is ordered differently between SBController & Boom -- notably the position of the space character.
Richard: was this done on purpose...
No, I think it keeps getting foobared during the language translation. It should be the same as on the player. Ben and/or Michael need to fix this.
The problem is that if we put the space character at the end or at the start of the charset, the SLT team returns it without the space. Thus, I stuck it in the middle, between the lower a-z and upper A-Z chars. I can change it back, but it will only result in SLT munging it again. Could we change the boom char menu instead?
How about appending/prepending the space character programmatically rather than relying on it being in the string
I could do that, though it would eliminate the possibility (well, without another hack) of using a charset that doesn't allow a space character, which seems like an plausible possibility.
it should be put back, and the scripts that process the output from SLT should verify the space is in the correct place for that token, and if not automatically correct it.
space added back to the start of the charsets, 7.1 change 21373 I'm going to take a quick look at the SLT scripts and see what I can do to add a hack fix for those two tokens and ensuring a prepended space char on the sets.
Created attachment 3518 [details] patch to make sure JIVE_ALLOWEDCHAR* tokens have a prepended space Michael, I think this will do it but as I don't have any way of testing, I'll just post this as a patch for you to look over and try.
thanks Ben. I'll test this after my vacation. Taking off the 7.1 radar.
Thanks Ben - change 22050
This bug has been fixed in the 7.3.0 release version of SqueezeCenter! Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already. If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.