Bugzilla – Bug 8604
SVN 21138 breaks URL parsing in songinfo / comments
Last modified: 2009-07-31 10:23:30 UTC
See: http://forums.slimdevices.com/showthread.php?t=49346 With the change to displaying songinfo comments now on their own page, URLs embedded in comments are no longer interpreted as links when the comment text gets processed. I'm in the habit of embedding links to pages on Grove Music in my comments. It used to be that these URLs were click-able and would open the link in a new tab. I think that SVN 21138 was the point at which this behavior changed.
Michael, can you see about making URLs clickable in XMLBrowser text items?
Could you please upload a sample file? I've entered a comment à la "here's a <a href="asf">link</>" and it does work for me. I can click it no problem.
Created attachment 3514 [details] Test files showing the problem These test files have album and track level comments with urls. Under the old behavior, the comment parsing code would construct the appropriate link ref when creating the songinfo html.
Michael: I see that your method works. But this is still been a change from the old behavior. The old code was able to identify that given a substring in the comment was a "naked" url and constructed the <a href> accordingly in the html. At least, that's what I think was going on. Anyway, it just worked in the old code. Also, the new behavior opens the link in the left frame, rather than opening it in a new browser window or tab, which was the old behavior. Making my comment tags compliant with the new behavior will mean having to edit and retag >40k tracks!
How did you edit these files? I can't see the information in easytag/Mp3Tag/Max (but SC does).
change 21366 - make urls in comments into links
Non-extensive testing, but change 21366 seems to work perfectly. Thanks!
This bug has now been fixed in the 7.1 release version of SqueezeCenter! Please download the new version from http://www.slimdevices.com if you haven't already. If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.
This bug has been fixed in the 7.3.0 release version of SqueezeCenter! Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already. If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.
Reduce number of active targets for SC