Bugzilla – Bug 8601
WavPack files with large RIFF headers not parsed correctly
Last modified: 2009-07-31 10:23:29 UTC
Created attachment 3508 [details] WavPack file showing parsing error (bad sample rate, etc.) I have found a minor problem with the WavPack.pm code. If a WavPack file is generated from a WAV file with a large RIFF header (over 4096 bytes) then the resulting WavPack file is not parsed correctly and weird data is returned for sample rate, bitdepth, and duration. The file still plays correctly because the wvunpack program does not have this bug. RIFF headers of that size are not common at all, but the recent free release of The Slip by Nine Inch Nails had 12288-byte RIFF headers, and that's how I discovered the problem. The actual issue is that the first block of the WavPack file ends up being dedicated to the RIFF header and no actual samples (or sample information) are present until the next block. I have created a test file that displays the problem by simulating this situation (I could not provide a track from The Slip because they're huge). Peter (who wrote the plugin) should have no problem providing a fix for this if he is available (I have cc'd him). If not, then I will try my hand at it (although I'm not fluent in Perl). Thanks!
Thanks, please assign this bug to me once you have a patch.
Created attachment 3516 [details] Fix for WavPack.pm I think this patch should fix the bug. It gives the correct information for the sample file (as checked against the command line wvunpack -ss command).
This patch works with all the files I've tested so far, and works with the problem sample file. Hopefully David will also be able to confirm with his music library.
Thanks, applied as 7.1 change 21350.
I have tested this fix extensively on both Windows and Ubuntu and it seems to both resolve the problem and not introduce any other issues. Thanks Peter and Andy!
This bug has now been fixed in the 7.1 release version of SqueezeCenter! Please download the new version from http://www.slimdevices.com if you haven't already. If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.
This bug has been fixed in the 7.3.0 release version of SqueezeCenter! Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already. If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.
Reduce number of active targets for SC