Bug 8591 - Fishbone left pane probem: not using Tan CSS, artwork link no longer works.
: Fishbone left pane probem: not using Tan CSS, artwork link no longer works.
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Skins
: 7.0
: Macintosh MacOS X 10.4
: -- normal (vote)
: 7.x
Assigned To: Unassigned bug - please assign me!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-06-27 14:14 UTC by Bradley Phillips
Modified: 2009-07-31 10:23 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments
screen shot of fishbone problem (406.26 KB, image/tiff)
2008-06-27 14:14 UTC, Bradley Phillips
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Bradley Phillips 2008-06-27 14:14:42 UTC
Created attachment 3504 [details]
screen shot of fishbone problem

In (still my favorite) skin Fishbone, the user can choose between two color schemes, "Black" and "Tan". Having selected the Tan scheme, if I click on a song in the right pane, the left pane song info comes up in the Black color scheme. (BTW, I'd love to see more color scheme options.)

Additionally (should this maybe be a separate bug?) In earlier versions of Fishbone, clicking on the left pane cover art thumbnail brought up a new window in the browser with the full size cover art. This no longer works, thumbnail is not recognized by the browser as a link.

Server is running on a OS X 10.4 machine, Firefox 3.0 browser running on 10.5 machine.

I include a screen shot.
Comment 1 KDF 2008-06-27 15:19:08 UTC
I suggest removing the css switching 'hack'.  It isn't something I'm interested in maintaining as I don't use them and they always require special hacks to get around any changes.  It was intended as a demo for possible future skin designs, and is clearly not ever something that will be globally supported. As such, it is just legacy cruft. I admit it was a bad idea and regret adding it.

The raw css files can still remain as examples, which users can swap out at will.

link problem has f* all to do with fishbone skin, as this is the songinfo page so is rooted in the EN template (a template which does appear to have it as a link). Please put this as a different bug, because the latter may be fixed, while former (imho) has a different solution.

Comment 2 Chris Owens 2008-06-30 10:05:38 UTC
Is there anything we can do to help you get rid of this 'hack', KDF?
Comment 3 KDF 2008-07-05 17:23:56 UTC
as long as multi-css option is only for one skin, it's always a hack.  It should just be removed unless someone else wants to keep maintaining it.  Every time a core template is changed, another workaround is required simply because this is a "one skin only" feature.
Comment 4 KDF 2008-07-07 13:49:12 UTC
note: I haven't yet tried on an osx machine, but using 7.1/7.2 on windows I'm not able to replicate the issue with FF3.
Comment 5 KDF 2008-07-15 22:33:23 UTC
having now tested with FF3 on osx, I still cannot reproduce the problem.  It's starting to seem like a caching issue, or something that's already fixed in more recent (7.0.1, or even 7.1+) builds.

I'd mark this off as a Works for Me, but since I'm no longer taking on ownership of the skin, I'll leave that for QA to decide.
Comment 6 KDF 2008-07-15 22:52:32 UTC
I found something and now is fixed for 7.1 at change 21795
Comment 7 James Richardson 2008-07-16 14:50:04 UTC
Bradley please retest with SqueezeCenter 7.1-21796.  if you still see the error, then reopen the bug with added comments.
Comment 8 Chris Owens 2008-07-30 15:33:31 UTC
This bug has now been fixed in the 7.1 release version of SqueezeCenter!  Please download the new version from http://www.slimdevices.com if you haven't already.  

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.
Comment 9 James Richardson 2008-12-15 12:33:00 UTC
This bug has been fixed in the 7.3.0 release version of SqueezeCenter!

Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already.  

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.
Comment 10 Chris Owens 2009-07-31 10:23:27 UTC
Reduce number of active targets for SC