Bug 8588 - Review SqueezePlay notifications
: Review SqueezePlay notifications
Status: NEW
Product: SB Controller
Classification: Unclassified
Component: Browser
: unspecified
: PC Windows XP
: -- normal (vote)
: Future
Assigned To: Unassigned bug - please assign me!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-06-27 12:21 UTC by Richard Titmuss
Modified: 2011-11-06 23:23 UTC (History)
0 users

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Richard Titmuss 2008-06-27 12:21:10 UTC
Review and clearly define when the server and player notifications are sent. Then all applets need reviewing for correct usage of the notifications.
Comment 1 Ben Klaas 2008-07-13 12:50:01 UTC
Richard, not sure if this is part of this bug or needs another--

Triode's applets (SetupNetTest, SetupAppletInstaller, and InfoBrowser) all attempt to add/remove themselves from the home menu using notify_playerCurrent methods. I've found that unless I've added the menu item already in the registerApplet method, the notification method is never called when a playerCurrent notification is sent out...

for example, if I do this, this meta file's notify_playerCurrent is never called:

function registerApplet(meta)
        jnt:subscribe(meta)

        meta.menu = meta:menuItem('appletInfoBrowser', 'extras', meta:string('INFOBROWSER'), function(applet, ...) applet:menu(...) end, 10)

end

function notify_playerCurrent(meta, player)
        if player == nil then
                jiveMain:removeItem(meta.menu)
        else
                jiveMain:addItem(meta.menu)
        end
end

but if I do this, the notification method gets called:

function registerApplet(meta)
        jnt:subscribe(meta)

        -- add the item to 'hidden' or playerCurrent notification below will never be called
        meta.menu = meta:menuItem('appletInfoBrowser', 'hidden', meta:string('INFOBROWSER'), function(applet, ...) applet:menu(...) end, 10)
        jiveMain:addItem(meta.menu)

end

function notify_playerCurrent(meta, player)
        if player == nil then
                jiveMain:removeItemFromNode(meta.menu, 'extras')
        else
                jiveMain:setCustomNode('appletInfoBrowser', 'extras')
        end
end


Is this behavior as designed? If not, any idea why it would behave this way?
Comment 2 Richard Titmuss 2008-07-24 05:06:24 UTC
punting to 7.3
Comment 3 Chris Owens 2010-05-07 10:28:45 UTC
Richard is no longer available to us.
Comment 4 Alan Young 2011-11-06 23:23:23 UTC
Unassigned bugs cannot have a priority.