Bug 8556 – TrackInfo shouldn't require a client object, as it can be called when browsing music without a player

Bug 8556 - TrackInfo shouldn't require a client object, as it can be called when browsing music without a player

Summary:

TrackInfo shouldn't require a client object, as it can be called when browsin...

Status:	CLOSED FIXED

Product:	Logitech Media Server
Classification:	Unclassified
Component:	Misc
Version:	7.1
Platform:	Macintosh All

Importance:	P1 normal (vote)
Target Milestone:	7.x
Assigned To:	Andy Grundman

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2008-06-25 00:25 UTC by Michael Herger
Modified:	2009-07-31 10:23 UTC (History)
CC List:	1 user (show)

See Also:
Category:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Michael Herger 2008-06-25 00:25:10 UTC

Should we add something like the following to Slim::Utils::Strings:

sub clientString
  my $client = shift;

  if ($client) {
    $client->string(@_);
  }
  else {
    string(@_);
  }
}

Comment 1 Michael Herger 2008-06-25 00:26:18 UTC

while working on the trackinfo page I often got lots of 

[08-06-25 09:16:44.0618] Slim::Menu::TrackInfo::__ANON__ (297) TrackInfo menu item "playtrack" failed: Can't call method "string" on an undefined value at /Users/mh/Documents/workspace/unstable/server/Slim/Menu/TrackInfo.pm line 551.
[08-06-25 09:16:44.0625] Slim::Menu::TrackInfo::__ANON__ (297) TrackInfo menu item "addtrack" failed: Can't call method "string" on an undefined value at /Users/mh/Documents/workspace/unstable/server/Slim/Menu/TrackInfo.pm line 551.
[08-06-25 09:16:44.0777] Slim::Menu::TrackInfo::__ANON__ (297) TrackInfo menu item "contributors" failed: Can't call method "string" on an undefined value at /Users/mh/Documents/workspace/unstable/server/Slim/Menu/TrackInfo.pm line 443.
[08-06-25 09:16:44.0941] Slim::Menu::TrackInfo::__ANON__ (297) TrackInfo menu item "album" failed: Can't call method "string" on an undefined value at /Users/mh/Documents/workspace/unstable/server/Slim/Menu/TrackInfo.pm line 663.
[08-06-25 09:16:44.1049] Slim::Menu::TrackInfo::__ANON__ (297) TrackInfo menu item "genres" failed: Can't call method "string" on an undefined value at /Users/mh/Documents/workspace/unstable/server/Slim/Menu/TrackInfo.pm line 735.

Comment 2 Andy Grundman 2008-06-25 06:22:13 UTC

Yeah I should have known better...

Comment 3 Andy Grundman 2008-06-29 06:49:05 UTC

Fixed in 7.1 change 21303.

Comment 4 Chris Owens 2008-07-30 15:27:42 UTC

This bug has now been fixed in the 7.1 release version of SqueezeCenter!  Please download the new version from http://www.slimdevices.com if you haven't already.  

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.

Comment 5 Chris Owens 2009-07-31 10:23:18 UTC

Reduce number of active targets for SC