Bug 8366 - Random Mix, Missing Functionality
: Random Mix, Missing Functionality
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Plugin
: 7.1
: PC Windows XP
: P2 normal (vote)
: 7.x
Assigned To: Michael Herger
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-06-09 11:39 UTC by Craig Garnett
Modified: 2009-07-31 10:22 UTC (History)
2 users (show)

See Also:
Category: ---


Attachments
adding functions handler back in (1.40 KB, patch)
2008-06-10 01:38 UTC, Michael Herger
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Craig Garnett 2008-06-09 11:39:40 UTC
The following code was removed from the Random Mix Plugin under change 20302.
It is used to enable mapping of a key press to start a random mix. 


sub getFunctions {

# Functions to allow mapping of mixes to keypresses
return {
'tracks' => sub { playRandom(shift, 'track') },
'albums' => sub { playRandom(shift, 'album') },
'contributors' => sub { playRandom(shift, 'contributor') },
'year' => sub { playRandom(shift, 'year') },
}
}

Craig
Comment 1 KDF 2008-06-09 12:01:00 UTC
Michael, do you recall why this was taken out at change 20302?
Comment 2 Michael Herger 2008-06-09 13:35:34 UTC
Wanted to get rid of hard coded dependencies. Maybe I was a bit optimisitic assuming everybody would now start using the newly introduced url to access mixes.

Will fix this.
Comment 3 KDF 2008-06-09 13:58:16 UTC
so, with the new urls, the rendom mixes can be assigned as favourites, which can be mapped at will to key presses (by default 0-9 are already mapped)?

That would mean this bit of code isn't needed.
Comment 4 Michael Herger 2008-06-10 00:52:51 UTC
Gee... please allow the noob question: how would I trigger those mixes? It's easy to put the function back in, but I don't know how to test :-/
Comment 5 Michael Herger 2008-06-10 01:38:24 UTC
Created attachment 3417 [details]
adding functions handler back in

does this patch work for you?
Comment 6 Craig Garnett 2008-06-10 15:27:33 UTC
(In reply to comment #4)
> Gee... please allow the noob question: how would I trigger those mixes? It's
> easy to put the function back in, but I don't know how to test :-/

I have this is my custom map,

7.hold   = modefunction_Slim::Plugin::RandomPlay::Plugin->tracks
8.hold   = modefunction_Slim::Plugin::RandomPlay::Plugin->albums
9.hold   = modefunction_Slim::Plugin::RandomPlay::Plugin->contributors

I could has a noob question on how do you attach this to a favourite?

Craig

Comment 7 Michael Herger 2008-06-11 08:55:27 UTC
change 20643 - I put the function handler back in for backwards compatibility. Thanks for the mapping example :-)
Comment 8 Chris Owens 2008-07-30 15:31:13 UTC
This bug has now been fixed in the 7.1 release version of SqueezeCenter!  Please download the new version from http://www.slimdevices.com if you haven't already.  

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.
Comment 9 Chris Owens 2009-07-31 10:22:34 UTC
Reduce number of active targets for SC