Bugzilla – Bug 836
flac files with cuesheets are not working properly in 6.0
Last modified: 2008-09-15 14:37:04 UTC
flac files that rely on cuesheets are not working properly in 6.0 those that rely on embedded cuesheets don't show up at all in the server. those with external cuesheets but no internal tags (depending on the cuesheet for metainfo) show up as a single song, with the name of the last track. The song link is set to play the entire file (no anchors present) those with external cuesheets and embedded metadata tags, show a number of songs that is one greater than should actually exist on the album. the final track in this list has it's name taken from the external cuesheet, and the link is set to play the entire file (no anchors set). The preceeding tracks are all listed as artistname - albumname and they have anchors, but looking at the anchors associated with them show that they're being listed in reverse order. one test case with both internal and external cuesheets is actually faring the best of the bunch, showing mostly correct info, but with an extra entry withh the name of the last track and referencing the entire file (no anchors). ironically, this is the only one that still has issues in 5.4
Update, as of revision 2020 Most things are working much better. Here's a few outstanding issues... A flac file using an external cuesheet that also has internal (multi-song) tags (but no embedded cuesheet) shows with an extra track at the top of the track list, which represents playing the entire file. This is probably an unusual use case, but it did work in 5.4 A flac with an external cuesheet and no tags of it's own works fine. Multi-disc sets are sorting with their songs intermingled. That is, disc1-song1, disc2-song1, disc1-song2, disc2-song2, etc. (I have "Treat multi-disc sets as a single album" set.) One band appears twice in "Browse Artists". In my small collection of test files, this band is in both a various artists collection, as well as having it's own album. One entry in "Browse Artists" contains only the various artists album, and the other entry contains only their own album. I haven't tried this against a large dataset yet, so I only have this one data point. I'll try it against a dataset with more overlap later, and see if it can be narrowed down better than this. Just for the record, a flac file with both internal and external cuesheets that differ in their contents still show up as a conglomeration of the two. This is consistent with 5.4 so it's not a show stopper. It's on my (low priority) list of things to address with respect to cuesheet handling however.
As for the duplicate artist entry I mentioned above, I've now pointed this at a larger dataset and found other instances of duplicated artist entries. So far I haven't found a common indicator of what causes one album not to match the others from the same artist. (Every example I've come across so far has only one album listed in one of the duplicated artist entries, and everything else by that artist in the other.)
Created attachment 270 [details] fix trailing space in embedded freedb metadata There is more than one issue behind the duplicate artist entries mentioned above. One cause has to do with trailing whitespace in the artist name. I've attached a patch to address one source of that trailing white space, but there may be others and it may also make sense to trim whitespace from various entries as things enter the db. Still tracking down the other cause(s) of duplicate artist entries.
update as of revision 2229... internal cuesheets seem to work pretty well files with an external cuesheet, will contain an extra entry for the bare file (this may show up under "No Artist / No Album" depending on how it's tagged.) multi-disc sets are still listed with their tracks intermingled, instead of ordered by disc.
Both of these have been fixed - subversion change 2265 for the metadata file. And change 2253 fixes the groupdisc problems.
There are 536 bugs in the database with targets of '---' that were fixed prior to new year 2006. I am setting them to targets of 6.2.1 to keep them from showing up in my queries.