So 20522 makes the knob push volume mode when turned in screensaver mode.  We can easily have this or "done" which will mean the knob wakes it up.  

Having "done" in some cases and "volume" in others requires more coding or a map clause per screensaver which will still not be based on stopped or playing screensaver definition as it will be upto the screensaver itself to define the operation unless we explicitly bypass the standard IR handling.

I like it.  

This seems to work for the non-Now Playing screensavers, but the Now Playing one still scrolls.  I suspect that this one will be a bit harder to fix.

Yep - the now playing saver is just the playlist mode and hence it does not use the screensaver entries in the ir map files.  Now Playing Jump Back on Wake should work.  

We would need to change how playlist works to something like the dual mode solution to get it to have its own mapping - alternatively we need a total hack in the ir code to guess when the we are in saver mode if you want this to work for now playing after the screensaver timeout but not before?

In theory, add to Buttons::Playlist::init()

Slim::Buttons::Common::addMode('SCREENSAVER.playlist', getFunctions(), \&setMode, \&exitMode);

then make that the screensaver version of the playlist module.  After that, you only need some extra logic in exitMode to do the non-jump or alter setMode to make sure the mode stack is cleared to set you back to top level on exit.

Yes somethink like this is probably possible - but need to track the cases where playlist is treated differently when popping.  Will look at later this week assuming Dean confirms this is the direction that is wanted...

Yes, please.  I think that this is the right thing to do.  Go for it!

Also, I think we probably want to reduce the default time for the screensaver to kick in to something like 15 seconds.

Thanks!

Based on some feedback, the knob-does-volume-not-scroll-when-only-one-item-in-now-playing behavior should probably die.  Just confuses people and I think the screensaver behavior is a better, more predictable, solution.

backed out the knob controls volume for playlists of one as of change 20803

Great, thanks.  

So, what's the feeling about the regular NP screensaver doing volume and not scrolling?

Checked in a try at now playing as change 20865 - I'm expecting feedback on this...

The issue is that now playing screensaver was not previously a screensaver and hence we can't use it to trigger volume.  This change makes now playing screensaver do two things: - set mode to playlist and then push 'screensaver' on top of this.

I am sure there are side effects of doing this, but I think its possibly preferable to having two modes mapping to S:B:Playlist as this keeps track of the current song in complex ways so I didn't want two versions of it on the modestack at one time..

see checkin 21048 in response to Andy's comment on campfire

This means there is no way to switch from volume mode to playlist scrolling with the knob.  

We need a definition of how the UI should work for NP screensaver to select between volume and playlist scrolling and whether there should be a visual clue on the mode.

When any screensaver is running (including the NP screensaver) the knob acts as a volume control and does not wake the screensaver.  

Pressing the knob (or pressing other buttons) does wake the screensaver and at that point the knob returns to being an up/down scroll control.

Does this clarify things?

Well that contracts Andy's requirement that pressing arrow_right when in NP screensaver goes straight into trackinfo rather than just exiting the volume mode and putting you into NP with knob = scroll through the list.

Change 21349 tries to strike a middle ground - the knob acts differently from other buttons and the remote so that arrow_right behaves as before, but pressing the knob in NP screensaver exits volume mode and puts you into the real NP mode where the knob scrolls through the list.

There will always be corner cases which people don't like with this approach as NP screensaver and NP mode do different things now and there is no visual clue as to which mode you are in...

I don't think we will keep everyone happy with this stuff.  Also need to review what happens on transporter once we are happy with what Boom does.  Should transporter change?  If not we need to update the firmware to have different ir codes for boom and tranports for knob_press.

Let me just say that I hate this, it is very annoying to press the knob on NP and get no feedback at all.  It will make people think their knob is broken.

I'm happy to revert the last checkin (or all of the knob=volume stuff)...

What we need is a clear definition of how it works which eveyone agrees with...  The main issue is that there is no visual clue as to which mode you are in and hence what the knob is likely to do.

After playing with it, I agree with Andy, pressing the knob should do _something_. It's probably best to have it behave as before, i.e. any button press (or knob press) wakes the screensaver and is passed through.

The exception to this would _only_ be the turning of the knob, which does not wake at all and only changes the volume.  

The side effect here here is that if somebody wants to scroll in the now playing list they'll have to press the knob and then the back button (or vice versa). 

That seems like a reasonable compromise, given that all the other buttons (including the up/down/left/right on the remote) continue to act as before.

I appreciate everybody's patience as we experiment with this stuff....

Reverted change - I think it should act as you describe but please try...

(In reply to comment #16)
> The side effect here here is that if somebody wants to scroll in the now
> playing list they'll have to press the knob and then the back button (or vice
> versa). 

Dean, what do you mean by this?  For me, I just press the knob (aka wheel) and I can scroll through the playlist.

Anyway, FWIW I think the current behavior is great.  I had a very non-technical friend visiting yesterday.  She was sitting next to the Boom when her phone rang.  Without thinking about it or looking at any button labels, she reached over and turned the knob to lower the volume.  I think that's the behavior you want...

That is the behavior you want, except when I'm in Pandora for instance and want to rate a song I reach over and press the knob... and nothing happens, because it's using that button to go from volume mode into menu mode.  So I press it again and now it works as I expect.

I think this is now in SCs hands. Let me know if something additional is needed in firmware to support this.

Agreed this is now down to SC - but I am hoping that what is there at present meets the requirements?  Assuming so I suggest we close this.

I have one more request.   If I go up and turn the knob and then immediately press the knob or left arrow, it doesn't come out of volume mode, it should.

Dean - try change 22127

Working well for me!  Nice job.