Bug 8277 - MusicIP requests are not async
: MusicIP requests are not async
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: MusicIP
: 7.0.1
: PC Windows XP
: P5 normal (vote)
: 7.x
Assigned To: KDF
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-05-30 10:34 UTC by KDF
Modified: 2009-09-08 09:15 UTC (History)
3 users (show)

See Also:
Category: ---


Attachments
step one (2.78 KB, patch)
2008-08-01 20:39 UTC, KDF
Details | Diff
step two (9.95 KB, patch)
2008-08-02 21:11 UTC, KDF
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description KDF 2008-05-30 10:34:26 UTC
they should be
Comment 1 Michael Herger 2008-05-30 13:16:09 UTC
Is it worth the hassle? I'm running MIP on a (nowadays) lowest end machine and never missed a beat due to the MIP communication. Maybe I need more music...
Comment 2 Chris Owens 2008-06-19 09:46:02 UTC
Do you have a rebuttal to help us decide, KDF? :)
Comment 3 KDF 2008-06-19 09:49:29 UTC
I never intended it to be a priority.  Andy mentioned it once so I remembered one day and thought it should be filed.  'future' would work, or perhaps as part of the 7.3 scanning changes.  Users are already talking of huge overhauls in metadata handling so much of MIP would be gutted for that anyway.
Comment 4 Chris Owens 2008-07-28 10:20:17 UTC
Michael notes we haven't had complaints.  Andy notes this is a substantial rewrite.
Comment 5 KDF 2008-08-01 20:39:31 UTC
Created attachment 3731 [details]
step one

this takes care of the high overhead checker.  the idea is that at least we can avoid a repeated warning when abusing http protocol handler and also avoid the blocked http call every 2 minutes.
Comment 6 Andy Grundman 2008-08-01 21:11:49 UTC
Great, this call is what I was most worried about too. :)
Comment 7 KDF 2008-08-01 21:41:05 UTC
the next one is the startup checks (as they do hold up things when they fail).  the trick is to make sure the response is there in time to continue anything that follows (ie scanning).  I'm not so up on the async stuff to be sure I'm catching the right cases and doing it the "best" way.
Comment 8 KDF 2008-08-02 21:11:24 UTC
Created attachment 3735 [details]
step two

this makes the init routine async as well, so now it shouldn't get in the way of startup if mip is disabled or not available.  I can't do much with grabMoods as it's called on the fly far too often.  I would like to make mixes async, but I have no idea how to hold off the page render results while waiting for the callback results.

Let me know if we can move this into 7.2 with the current patch, or if it should just be committed to 7.3
Comment 9 Andy Grundman 2008-08-03 05:05:45 UTC
Cool, let's get these into 7.2.
Comment 10 KDF 2008-08-03 10:50:48 UTC
change 22329 contains the init and checker fixes.
Comment 11 Blackketter Dean 2008-08-06 13:16:44 UTC
Should we close this bug?
Comment 12 KDF 2008-08-06 13:50:42 UTC
I think the worst offenders are handled now.  Given that the rest depend on already knowing that the plugin is working, connect to MIP is working and that we know that MIP is more than likely running on the same machine it should be safe to assume that the remaining blocking requests will not block for long.  They will, however, continue to cause warnings when they hit the standard http protocol handler (which expects a song reference)

More important reason to close, I really don't have a clue how to do any more than I have on this one :)
Comment 13 Andy Grundman 2008-08-06 13:57:07 UTC
Yeah I'm fine with it now.
Comment 14 Chris Owens 2009-07-31 10:21:59 UTC
Reduce number of active targets for SC