Bug 8270 - Change "Go right to add to favorites" to "Add to Favorites" on Boom
: Change "Go right to add to favorites" to "Add to Favorites" on Boom
Status: RESOLVED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Player UI
: unspecified
: PC Other
: -- normal (vote)
: ---
Assigned To: KDF
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-05-29 10:06 UTC by Brian Dils
Modified: 2009-09-08 09:18 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Dils 2008-05-29 10:06:23 UTC
Since the users could be using the front panel on Boom, this change needs to be made so that we don't reference "going right"
Comment 1 KDF 2008-05-29 13:16:43 UTC
Just for boom, or generally (Transporter has a knob too)?  Which target?
Comment 2 Blackketter Dean 2008-05-29 22:30:23 UTC
Please change for all platforms.
Comment 3 KDF 2008-05-29 22:41:51 UTC
private-branch or earlier?
Comment 4 KDF 2008-05-29 23:14:59 UTC
come to think of it, there are a lot of places where the strings say "press right.." or "go right...".

Alarms, for example and I'm sure I can find others.

That also brings to mind the various toggle displays

"off (press right to turn on)  [ ]"
"enabled (press right to disable) [ ]"

If the toggle checkbox is there, do we really need to have on/off, or enabled/disabled?

Why not "Enable []" and leave it at that? We'd probably get rid of a lot of redundant strings that way
Comment 5 Blackketter Dean 2008-05-30 06:24:01 UTC
Yeah, those are bad and should be fixed, although:

"Enable   [x]"

Isn't probably the best wording, since the checkbox also means "enable".  

I'd prefer:

"Alarm                Off"

and 

"Alarm                On"

Though Brian might have a better suggestion.

Brian:  Please take the time to go through the whole UI and see what else you can find and file the necessary bugs.  

KDF:  Thanks for spotting the stuff we miss...
Comment 6 KDF 2008-05-30 07:54:09 UTC
you are welcome.
what about 
"Alarm [x]"
"Alarm [ ]"

That would be consistent with the wiki at least.  That, or maybe think about a different standard for on/off that can be more consistent.
Comment 7 Blackketter Dean 2008-05-30 09:39:34 UTC
SBC uses the form:

"Repeat              Album"

and that works well for that setting.

Alarm          [x]

or 

Enable        [x]

doesn't really tell you what it does.

I can update the wiki, but most important is that it's clear to the user what the setting does on one line.





Comment 8 KDF 2008-05-30 09:43:11 UTC
agreed.  wiki just makes sure that what gets done can be done with the same styles. It needs a bit more cleanup in order to get rid of the checkbox ui for those cases and get the right result for the "word" ui.
Comment 9 Brian Dils 2008-05-30 10:12:30 UTC
I think the style of "setting" [status] works best for me.  So for example Alarm [on] when you hit the menu, but as you go up and down it changes. Going left or right saves the change if you made one. We could even use "is" to make it clearer, but I don't think it necessary. ex. "Alarm [is On]"
Comment 10 Brian Dils 2008-05-30 10:14:22 UTC
Do I need to do a factory reset first to get Boom to update to the nightly?  Mickey mentioned that he had to do that and I haven't seen Boom update in a while...
Comment 11 KDF 2008-05-30 10:42:02 UTC
I think this is getting bigger than I thought.  We'll probably have to move this discussion somewhere else.  Toggle setting like the alarm don't current scroll as they simply appear in the main list and toggle when you press right/add/play.  To scroll, we'd have to push right then choose off/on.  
Comment 12 KDF 2008-05-30 23:58:24 UTC
change 20393 removes the "go right" references.  This made one favourites string redundant so I removed it and converted the users to the existing token.

calling this one closed.  If we want to revisit the alarm ui (and by extension other toggle/status settings, please open a new bug)