Bug 8253 - checkBoxOverlay ui is a radio button
: checkBoxOverlay ui is a radio button
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Player UI
: 7.0.1
: PC Other
: -- normal (vote)
: 7.x
Assigned To: KDF
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-05-27 22:18 UTC by KDF
Modified: 2009-09-08 09:22 UTC (History)
0 users

See Also:
Category: ---


Attachments
patch (2.92 KB, patch)
2008-05-27 23:15 UTC, KDF
Details | Diff
missed one (5.14 KB, patch)
2008-05-28 00:41 UTC, KDF
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description KDF 2008-05-27 22:18:11 UTC
The current player UI feature for checkBoxOVerlay is a radio button.  It is currently used both for single select/toggle and for multi-select lists.  The multi-select should be a checkbox, while single-select should be radio button.

I assume single toggle should be radio button as well?

This involves changes to Input.Choice, a new function in Buttons::Common for radioButtonOverlay and updates to the wiki page:
http://wiki.slimdevices.com/index.php/UserInterfaceGuidelines
Comment 1 KDF 2008-05-27 23:15:25 UTC
Created attachment 3376 [details]
patch

I believe this should cover the core cases, and anyone using INPUT.Choice.  Multiple options will result in a radio button. All other cases that are already calling checkBoxOverlay will get the square checkbox. 

the only one I'm not sure about is the XMLBrowser.  What cases use type=radio in the xml that need displaying and selection?  For now, I've gone with a radio button.
Comment 2 KDF 2008-05-28 00:41:41 UTC
Created attachment 3377 [details]
missed one

just to cover the audioscrobbler settings and alarm playlist selection
also adds some clear POD for the overlay functions
Comment 3 KDF 2008-05-30 00:31:38 UTC
change 20325 merges the latest patch.  If the toggles are not right, please reopen.
Comment 4 Chris Owens 2008-07-30 15:33:10 UTC
This bug has now been fixed in the 7.1 release version of SqueezeCenter!  Please download the new version from http://www.slimdevices.com if you haven't already.  

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.
Comment 5 Chris Owens 2009-07-31 10:21:47 UTC
Reduce number of active targets for SC