Bugzilla – Bug 8211
Bass, Treble and StereoXL should appear in settings.
Last modified: 2008-12-15 11:58:31 UTC
Bass and Treble already have settings, but are only enabled for SB1 now. They need to be enabled for Boom too and have the right commands sent to the player. StereoXL should have a similar UI.
are max and min for bass/treble still 0 and 100 for boom? If someone can tell me what commands need to be sent in order to set bass/treble on boom, I'll add the code to call those commands.
From a UI point of view, I think it should be maybe a range of +- 10 (unitless). Any thoughts?
-100 to 100 seems reasonable and we're already doing that. (I realize that we don't have full resolution with less than 80 pixels either way, but as long as we can hit zero, -100 and +100 exactly, that'll be fine.) Caleb: What parameter should kdf send?
Do the commands come from the server? We can do it either with bdac commands, or make up new higher level commands. I guess we can start with bdac commands, the change them to high level commands later on once the firmware supports them. The bdac commands are low level i2c commands. Just reenable stuff, then assign me the bug with a pointer where to add my code to generate commands.
will do. just need to sort out the handling for the different ranges.
minor annoyance: mixer commands assume values with +/- are relative. This means trying to set the bass directly to -100 is a problem. This requires some tweaks to INPUT.Bar.
change 20071 adds treble and bass control for boom player ui. stereo xl is roughed in, but needs mixer command support to enable properly. I've marked the two places in Player::Boom which need the bdac command (see treble() and bass()) I've had to rework INPUT.Bar to use relative adjustments in order to handle the negative values. It appears to work, but we'll need to test more of the callers.
These settings need to be synced with SC and put into the DSP. Dean, should this be done by 7.2?
Yes please. KDF pulled out some of it after this was updated, but it can be rolled back in when the the audio back-end part is ready.
Kevin - the change to Input.Bar to use relative values seems to cause issues with other code using that input method (see eg. bug 8332). What needs to be done to make those other users happy?
These items now show up in the Player UI, but adjusting them has no effect
james, that was noted in the commit log, forums and comment 7. There is no hardware function for the features as yet. Once again, I'm happy to rip them out for a second time if it's really so confusing to have a ui that doesn't control the hardware until firmware catches up.
Don't rip it out. I'll work on this now. -C
All 3, Bass, Treble, StereoXL work now (as of r21274). You must use the latest posted dsp image at http://forums.slimdevices.com/attachment.php?attachmentid=5346&d=1214524724, in this thread: http://forums.slimdevices.com/showthread.php?t=49276. Should only be necessary until FW 17 is released.
Verified functioning properly with r19 & 7.2-22118 and they actual do something :)
This bug has been fixed in the latest release of SqueezeCenter! Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already. If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.