Bug 8184 - Cannot upload wallpapers with Danish characters in the filename
: Cannot upload wallpapers with Danish characters in the filename
Status: RESOLVED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Web Interface
: 7.1
: PC Windows XP
: -- normal (vote)
: ---
Assigned To: Adrian Smith
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-05-17 13:28 UTC by Mikkel Herold
Modified: 2008-06-07 14:30 UTC (History)
2 users (show)

See Also:
Category: ---


Attachments
Screendump of the Customize Controller screen (145.27 KB, image/png)
2008-05-17 13:28 UTC, Mikkel Herold
Details
Corrupted png file after upload (97.39 KB, image/png)
2008-05-19 05:31 UTC, Mikkel Herold
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Mikkel Herold 2008-05-17 13:28:13 UTC
Created attachment 3355 [details]
Screendump of the Customize Controller screen

When you want to upload new wallpapers to use on the Controller, SC will not accept images that have one or more of the special Danish/Scandinavian letters "æ", "ø" or "å" in them.

If you select such an image the filename does appear in the Browse box, and when you click to save it, it seems to be saved too, and a box for the next image appears - but there is no thumbnail of the supposedly uploaded image to the left of the text boxes.

The attached screendump shows the problem: The wallpaper named "TEST" is a file named "måne.png" - there is no thumbnail like there is for the other three images above it.
Comment 1 Michael Herger 2008-05-19 01:21:38 UTC
I assume there's an image link to the left of the field, but it's not showing, as SC can't find the file or something. Can you confirm this? If you do, what's the image's link you see?
Comment 2 Michael Herger 2008-05-19 01:50:29 UTC
Triode - that's another case where we have to turn off utf8 on a pref:

Index: /Users/mh/Documents/workspace/Teststoff/Slim/Plugin/JiveExtras/Settings.pm
===================================================================
--- /Users/mh/Documents/workspace/Teststoff/Slim/Plugin/JiveExtras/Settings.pm	(revision 19874)
+++ /Users/mh/Documents/workspace/Teststoff/Slim/Plugin/JiveExtras/Settings.pm	(working copy)
@@ -69,7 +69,7 @@
 
 					my $opt = {
 						'name' => $params->{"${optname}_name$i"},
-						'url'  => $params->{"$optname$i"},
+						'url'  => Slim::Utils::Unicode::utf8off($params->{"$optname$i"}),
 						'key'  => "JiveExtras_$j.$ext",
 						'vers' => undef,
 					};

This would work for me. I'm not sure whether we can apply the setUtf8Off() in this case?

What about case sensitivity? I noticed  I wouldn't see any of my digicam pictures, as it uses uppercase .JPG by default. Shouldn't we allow mixed cases?
Comment 3 Mikkel Herold 2008-05-19 05:29:49 UTC
(In reply to comment #1)
> I assume there's an image link to the left of the field, but it's not showing,
> as SC can't find the file or something. Can you confirm this? If you do, what's
> the image's link you see?

The image link (from the source code) is http://192.168.1.100:9000/jivewallpaper/JiveExtras_3.png

If I try to download that image, it does suggest the correct filename ("måne.png"), but the file seems corrupted.

I have attached the downloaded (corrupted) file.
Comment 4 Mikkel Herold 2008-05-19 05:31:27 UTC
Created attachment 3357 [details]
Corrupted png file after upload

This is the file I get when I download http://192.168.1.100:9000/jivewallpaper/JiveExtras_3.png

It seems corrupted.
Comment 5 Adrian Smith 2008-05-19 13:48:42 UTC
Fixed in change 19909 please try the next nightly
Comment 6 Mikkel Herold 2008-05-22 16:43:34 UTC
Works now (20009), but there is a minor bug still: The scandinavian character in the filename shown in the Browse textbox is somehow encoded.

Thus, the filename "måne.png" is shown as "mÃ¥ne.png".
Comment 7 Adrian Smith 2008-06-07 14:30:02 UTC
Fixed in change 20486.