Bugzilla – Bug 8163
Playlists folder is forced if Use local music is not checked.
Last modified: 2009-07-31 10:21:30 UTC
During install if a user unchecks Use local music it will force a Playlists Folder to be used. I think it should be none just like the Music Folder. Steps to reproduce: 1. Run the installer on a clean system and open SqueezeCenter and the wizard should start. 2. On the Music Source screen uncheck Use local music. 3. On the next screen notice that under Music Source a playlists folder is filled in.
Steven to check this out under 7.1. Michael notes he has changed most of the wizard code in 7.1. Assign to Michael if there's still a bug.
Just tried with 7.1 20899 and it still forces a Playlists folder during install.
I still don't see this. Are you sure you've removed any trace of server.prefs? And fully reloaded the browser window and everything?
Yes, I removed all traces of SqueezeCenter. I also wanted to note that I see this behavior on both Mac OS X and Win XP.
I will try describing the steps in more detail. 1 Start with a system that has no trace of a previous SlimServer/SqueezeCenter. I am using Mac OS X 10.4.11 for this example. 2 Run the installer. 3 Once the installer has finished click Start Server. 4 Once the sever is running click Web Access. 5 Browser should open on the Setup Assistant. 6 Click Next. 7 SqueezeNetwork Account page should now be open. 8 Click Skip 9 Music Source page should now be open. 10 Make sure that Use local music is not checked. 11 Click Next. 12 Summary page should now be open. 13 Notice that a Playlist Folder directory is filled in under Music Source even tough the user was not given a choice to select one. It also appears that the Setup Assistant created the folder if one did not exist. Let me know if you need more information.
Oh, by "forcing" you mean it's displayed on the summary page? I thought you were presented the folder selector... I can confirm this "misbehaviour" (almost not worth the time you had to spend to explain to me ;-))
change 20941 - thanks!
By forcing I mean that if the user unchecks "Use local music" the wizard does not offer an opportunity to select a Playlist Folder. This results in the wizard selecting one on its own and even creating said folder if it does not exist on the system. The behavior I was expecting is that the wizard would present the user the opportunity to select a playlist folder even if they uncheck use local music. If it makes more sense to not present the user with the opportunity to select a playlist folder when use local music is unchecked then the behavior I would expect is the playist path to be blank just like the music path in this situation. The thing is I am not really sure when the Playlists Folder gets created. Is that done by the wizard or the installer or even SqueezeCenter itself? Different bug perhaps?
Now this is getting a bit strange... > By forcing I mean that if the user unchecks "Use local music" the wizard does > not offer an opportunity to select a Playlist Folder. This results in the > wizard selecting one on its own and even creating said folder if it does not > exist on the system. SC does _not_ create folders except for the cache/log/prefs. What folder do you see being created? And when you reported this bug, the wizard had been so utterly broken for several months, it did not even store the settings you chose. I don't know why nobody ever noticed this. > The behavior I was expecting is that the wizard would present the user the > opportunity to select a playlist folder even if they uncheck use local music. That's what I thought you were complaining about in the first place: seeing the playlist selection page though you had music folder disabled? But you actually want it? > The thing is I am not really sure when the Playlists Folder gets created. Is > that done by the wizard or the installer or even SqueezeCenter itself? What OS? Windows does have a default playlist folder. It's created by Windows. Can you monitor the place you see it appear while doing a _very_ clean install from scratch? Step by step you might guess whether it's the installer or SC.
(In reply to comment #9) > Now this is getting a bit strange... Yes, it is ;) > SC does _not_ create folders except for the cache/log/prefs. What folder do you > see being created? With a clean install of 7.1 20941 on Mac OS X 10.4.11 I see a Playlists folder created in the Music folder the first time that SqueezeCenter is run after install. No idea why. > That's what I thought you were complaining about in the first place: seeing the > playlist selection page though you had music folder disabled? But you actually > want it? I never saw the playlist selection page during install with music folder disabled. I don't actually have a problem with this. What I was initially attempting to point out, but failing miserably, is that a music folder was selected on the last page of the wizard even when the user was not given the opportunity to select one when music folder was unchecked. I am begging to think that the music folder is actually created and selected before the wizard is even run. Is that a possibility? > What OS? Windows does have a default playlist folder. It's created by Windows. > Can you monitor the place you see it appear while doing a _very_ clean install > from scratch? Step by step you might guess whether it's the installer or SC. Have been testing with Mac OS X. Have not gone back and tested against Windows yet.
I just wanted to note as an experiment I did another clean install of 7.1 20941 on Mac OS X 10.4.11. Before starting SqueezeCenter for the first time I disabled write access of just the Music folder. I was surprised to find that this prevented SqueezeCenter form running after a clean install.
- stopped SC - removed Music/Playlists folder - removed server.prefs - restarted SC - run the wizard - selected iTunes as my music source -> no folder is being created Either I don't understand your issue, or I really can't reproduce it. (running 10.5.3)
One more thing: I searched the source code for the "mkdir" instructions and only found it related to the cache/log/prefs folder.
Created attachment 3477 [details] Error starting SqueezeCenter when music directory is write protected Maybe I am going mad, but this is the error I get when starting SqueezeCenter the first time after a clean install on Mac OS X 10.4.11 from the command line. I will try with Mac OS X 10.5.3 and see if I get the same behavior.
Shame on me... sure: the mkdir is in the prefs module. But it's there to create some default folders... I stand corrected. Is all you want not to create that folder unless a user defines it? Does it really matter? :-) (But why doesn't it create a folder on my system?)
(In reply to comment #15) > Is all you want not to create that folder unless a user defines it? Yes, I would like SqueezeCenter to never create a playlist folder nor select a playlist folder unless the user explicitly selects one. The selecting of this folder can be done during the wizard or afterward with the playlist dialog box. The playlist dialog should be empty otherwise. > Does it really matter? :-) It matters to me ;-) > (But why doesn't it create a folder on my system?) No idea either, I see the same behavior as reported with my Mac OS X 10.5.3. Any idea why forcing of the playlist folder was implemented? I seem to remember the playlists folder was always optional in the past.
> > Does it really matter? :-) > It matters to me ;-) In all respect... I don't know whether we should change this behaviour. I fear there could be unexpected side-effects which just aren't worth the hassle. The code/behaviour has been there forever (only went back three years - rev. 3924). Why is it annoying you? > Any idea why forcing of the playlist folder was implemented? I seem to > remember the playlists folder was always optional in the past. During very first start (_before_ the wizard is run) some prefs are initialized and preset with some default value. defaultPlaylistDir has been there since at least r516, the mkpath statement (not mkdir what I was looking for earlier...) since r3924. Even the audioDir is preset(!), though not forced/created if not available. What we could easily do without breaking things too easily is probably remove these values again if a user decides not to use the music path.
Ok, finally found it: bug 1171 (Dean) asked for the playlist dir to be created in SS6.0
change 21066 - fix a related issue where the wizard would set audiodir/playlistdir even if it was disabled
Michael, change 21066 looks great and seems to solve all of the wizard issues I have seen, thank you! I am not concerned so much about the creation of the Playlist folder now that the wizard is working for me. I'm sure you are correct that we should just leave that alone for now. After reading bug 1171 I still don't understand why forcing the creation of a Playlists folder has anything to do with iTunes.
This bug has now been fixed in the 7.1 release version of SqueezeCenter! Please download the new version from http://www.slimdevices.com if you haven't already. If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.
This bug has been fixed in the 7.3.0 release version of SqueezeCenter! Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already. If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.
Reduce number of active targets for SC