Bugzilla – Bug 8123
enhancements to CustomizeHomeMenu applet
Last modified: 2009-09-08 09:19:21 UTC
from an email from Dean->Ben: - Let's call it "Home Menu" and lose the "Customize" - "Restore Menu Defaults" should go to the end and can be renamed: "Restore Defaults" - The order of the items should follow the order that they appear on the home menu by default: Now Playing, Music Library, Internet Radio, Music Services, Favorites, Extras, Choose Player, Turn On - Some of the settings probably should be omitted: Advanced Home Menu :) Factory Reset Factory Test (and everything underneath it) - In Settings, Advanced should remain last. Home Menu can come right before it. - The indented approach is probably the next thing we should try. Trying to find the thing you want to add to the home menu is really hard right now... - It would be good to be able to customize the name of the thing that goes on the home menu sometimes. Music Library -> Search -> Albums should probably be "Album Search" and not just "Albums" - The order of stuff added to the home menu should match the order that they appear in the hierarchy. (i.e. once you add the indented structure, the items should appear in the same order as the Home Menu setting list.) Does that make sense?
r2446 on Jive 7.1 trunk fixes these items: - Let's call it "Home Menu" and lose the "Customize" - "Restore Menu Defaults" should go to the end and can be renamed: "Restore Defaults" - Some of the settings probably should be omitted: Advanced Home Menu :) Factory Reset Factory Test (and everything underneath it) - In Settings, Advanced should remain last. Home Menu can come right before it. with the exception that I am still exposing "Home Menu" as an item that can be put on the top menu. It's useful, at least for me right now. I'm not sure it really needs to be omitted from the list. this leaves: - The indented approach is probably the next thing we should try. Trying to find the thing you want to add to the home menu is really hard right now... - It would be good to be able to customize the name of the thing that goes on the home menu sometimes. Music Library -> Search -> Albums should probably be "Album Search" and not just "Albums" - The order of stuff added to the home menu should match the order that they appear in the hierarchy. (i.e. once you add the indented structure, the items should appear in the same order as the Home Menu setting list.) Does that make sense? - The order of the items should follow the order that they appear on the home menu by default: Now Playing, Music Library, Internet Radio, Music Services, Favorites, Extras, Choose Player, Turn On
SC 7.1 trunk change 19649 and Jive 7.1 trunk r2447 fix this: - It would be good to be able to customize the name of the thing that goes on the home menu sometimes. Music Library -> Search -> Albums should probably be "Album Search" and not just "Albums" which leaves: - The indented approach is probably the next thing we should try. Trying to find the thing you want to add to the home menu is really hard right now... - The order of stuff added to the home menu should match the order that they appear in the hierarchy. (i.e. once you add the indented structure, the items should appear in the same order as the Home Menu setting list.) Does that make sense? - The order of the items should follow the order that they appear on the home menu by default: Now Playing, Music Library, Internet Radio, Music Services, Favorites, Extras, Choose Player, Turn On
cc:ing Jim, who seems to be all over this applet :) significant enhancements in 7.1 SC 19739 and Jive 7.1 r2454. What works: items in the 'Home Menu' applet now reflect the hierarchical structure of all home menu items. items added to the top level menu with this applet will be positioned in the same sort order as in the applet. indentation works within the applet settings is not available for removal from the top level menu, but do appear in the applets home menu list (without checkboxes) in order to give some clarity to what's presented below them. What doesn't: custom text on the top level (e.g., "Album Search" instead of "Albums"), which did work, no longer does. That's due to the need to have a lot of this code managed by the HomeMenu class. related to that, while submenu items are indented in the applet, they are not indented when added to the top level menu, for the same reason as custom text.
this was an email to Richard, but should probably be documented in the bug. cc:ing Richard for comment hi Richard- I'm stuck on a problem with the CustomizeHomeApplet... The problem I'm having is that I'm trying to co-home a menu item in two spots, under two different contexts (home and its default location). When a non-home item is customized to home, the text label needs to be different sometimes, as well as to be indented (e.g., ' Album Search' vs. 'Albums'). The problem I'm running into is that if I change item.text, the text changes in both locations. I have been trying to adapt SimpleMenu._itemRenderer to render the label text differently depending on context, but the only way I've figured out how to identify context is by using self, which _itemRenderer doesn't have access to. Any ideas? #!/ben
I'd like to urge you to consider replacing the pinned settings entry with a pinned full menu entry which leads to the uncustomized menu tree. This avoids having to enable a rarely used item just to use it, and then disable it again to clean up the customized menu. And of course, it guarantees that you can always reset things.
Marc, you are going to have to clarify that last comment. I don't understand what you're asking for.
Sorry to be obtuse. today, to avoid getting the user trapped, customize forces settings to be on the home menu - you can't disable it. what I'm proposing is that a new menu entry, full menu, be added. Full menu takes you to the top of the complete, uncustomized, menu tree. Full menu is pinned, in the sense that it must be on the customized home menu. The point is that one of the down sides of a customized menu is that you occasionally need one of the entries you've disabled. To use it, you have to first re-enable it, then use it, then disable it again. So a full menu entry would avoid that nuisance, and would also serve to guarantee that you could get back to the customize home menu part of settings, since settings it under full menu. Thus, full menu can replace settings as the only entry that the customized home menu is force to contain.
Ben re #4, you'll need to create two item tables that get used in the different contexts.
r2515 should bring this bug to completion. Marc, I'm considering your request a separate enhancement, and opened 8217 against it.
Verified fixed in: SqueezeCenter 7.1-21796 Controller 7.1 r2699
This bug has now been fixed in the 7.1 release version of SqueezeCenter! Please download the new version from http://www.slimdevices.com if you haven't already. If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.
This bug has been fixed in the 7.3.0 release version of SqueezeCenter! Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already. If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.