Bug 8119 - undocumented change to radios command format
: undocumented change to radios command format
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: CLI
: 7.0.1
: PC Windows XP
: -- normal (vote)
: 7.x
Assigned To: Andy Grundman
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-05-11 04:10 UTC by Barry Gordon
Modified: 2009-07-31 10:21 UTC (History)
2 users (show)

See Also:
Category: ---


Attachments
radios query should not require client (4.10 KB, patch)
2008-05-11 13:19 UTC, Michael Herger
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Barry Gordon 2008-05-11 04:10:21 UTC
CLI Interface.

Issuing a 'radios 0 10' to start getting the Internet radios list returns a result with a playerID placed in front of the return as an added field. Is this correct as I do not recall any CLI command returning a response that did not begin with what was sent. This allowed for easy detection of "Unsolicited traffic" such as those from listen or subscribe. 

I also see the same behavior when issuing commands one level deeper, i.e the actual internet radio system e.g. shoutcast. 

If this is a CLI specification change, no issue; just point me to where I can read about it so I can handle it in the proper manner

Thanks
Comment 1 Michael Herger 2008-05-11 13:19:03 UTC
Created attachment 3335 [details]
radios query should not require client

Use $request->string() instead of $client->string()
Comment 2 Barry Gordon 2008-05-11 13:48:21 UTC
I am assuming by your comment that you agree with me and it will be rectified. Also be sure and catch the fact that as you dive down in to tree the same things happen.

Thanks.  I really do enjoy dealing with you. It is always a pelasure!
Comment 3 Michael Herger 2008-05-12 13:05:14 UTC
Please note that my comment to the patch only tells part of the story. What I did is remove the requirement for the radios query to have a client. I'm not even sure whether this will work with all radio stations - Andy might know better. 

The string() change is only due to the fact that we now can't rely on having a client ID in our query.
Comment 4 Andy Grundman 2008-05-12 13:29:32 UTC
Fixed in change 19643.  The radios and music_services command won't require a client now.  I updated the CLI docs a bit to mention that playerid is required for actually browsing these sources though.
Comment 5 James Richardson 2008-05-13 16:08:07 UTC
Barry: Can you please verify that the changes made in 7.0.1- 19643 (or later builds) work for you
Comment 6 Barry Gordon 2008-05-15 12:21:39 UTC
Works for me.  I changed my code to allow a radio ID at any time to maintain backwards compatibility
Comment 7 James Richardson 2008-05-15 12:25:45 UTC
This bug has recently been fixed in the latest release of SqueezeCenter 7.0.1

Please try that version, if you still see the error, then reopen this bug.

To download this version, please navigate to: http://www.slimdevices.com/su_downloads.html
Comment 8 Barry Gordon 2008-05-15 12:32:48 UTC
It is fixed.
Comment 9 Chris Owens 2009-07-31 10:21:18 UTC
Reduce number of active targets for SC