Bugzilla – Bug 8116
SongScanner key defs should be in default.map
Last modified: 2009-09-08 09:29:22 UTC
Since it appears that songscanner is now a required pluggin, its key definitions should be in default.map rather than dynamically installed in initPlugin. The difference is that keys in default.map can be overridden using a custom.map I swap fwd/rev and fwd/rev-hold function - but this won't work properly with current implementation.
good point. target 7.1, I suppose?
common mode functions should certainly move. not sure about the plugin mode buttons. Then again, maybe it's better as a button module since it's an enforced plugin anyway. That is essentially what the Button/* and Web/Pages/* modules are.
So what work needs to be done here? Since this bug wasn't assigned to anyone it's kind of fallen through the cracks.
Created attachment 3460 [details] move mappings something like this needs to be done. I don't think the other buttons should be moved, as this is specific to the plugin mode itself. Normally that would have been in the %functions, but the addModeDefaultMapping call does pretty much the same thing.
KDF, I guess that is fine if we are happy with SonScanner being mandatory. The old (current) behaviour allows one to disable the SongScanner plugin and then get the old accelerated-audio behaviour. This patch would remove that option but it would not be difficult for a user that cares to change the mapping in this case. Do you want to commit this?
I'll assign to me as a todo, but since it's targetted for 7.2 and I'm currently busy packing for a flight to the UK, I'll hold off for now. Let's be sure that permanently on SongScanner is what is desired.
well, I'll merge this in, but Dean has to decide if having songscanner changed to a forced-enabled plugin. users wanting the older scanning can change the map file (though I realise that's almost never considered an accepted option)
Thanks, KDF. Is this merged in?
not merged yet. I want to know if we should make the plugin mandatory as per alan's query. Otherwise, the mapping would be a problem should a user disable the plugin.
ping Dean, Any chance of a confirmation here? This change would make the scanner mandatory as a plugin. Users can only bypass with a custom map
Dean says go ahead and commit!
Change 22519. no change in song scanner enforce status, as it appears it was already mandatory :)
This bug has been fixed in the 7.3.0 release version of SqueezeCenter! Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already. If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.
Reduce number of active targets for SC