Bugzilla – Bug 8107
Play All Seach Results does not show up as option on SB
Last modified: 2009-07-31 10:20:59 UTC
When Searching for music (song, artist album) using the SB & remote the search results no longer have the "Play All" option. (eg search from remote for all songs that have the word "Baby", which returns say 20 songs, I want to play all those 20 songs from the search results, and not add them one by one) This option shows up in the web UI, and DID show up on the SB via the remote at slimserver 6.5x (the results would have one top level entry of PLAY ALL), but since upgrading to 7 this doesn't show up, nor can I find a setting to have this. This happens w/ 7.0 & the latest 7.0.1 nightly (at this time 19572), & 7.1. Thanks.
The bug only appears in the Player UI
change 13237 is partly to blame here. ALL item is suppressed at top level. This is mostly due to the ability to play all by playing the top level of each browse menu item. This doesn't really work for Search, so we can probably re-enable in the search case. Index: C:/slim/server/Slim/Buttons/BrowseDB.pm =================================================================== --- C:/slim/server/Slim/Buttons/BrowseDB.pm (revision 19607) +++ C:/slim/server/Slim/Buttons/BrowseDB.pm (working copy) @@ -780,7 +780,7 @@ } # Then see if we have to add an ALL option - if (($descend || $search) && $count > 1 && !$rs->suppressAll && $level) { + if ((($descend && $level) || $search) && $count > 1 && !$rs->suppressAll) { # Use the ALL_ version of the next level down in the hirearchy if ($descend) { the problem is, doing that causes the db lookup to barf on *.titlesearch params
Should we make this change?
Ben do you have any input on this bug?
The checkin referred to in this bug was added so as not to have a "Play All" item on top level SBC lists like "Albums" I tested the suggested fix from KDF and "Play All" now shows up in PlayerUI without affecting any of the desired behavior of jiveUI. I don't know enough about the db lookup to have an opinion on the "barf on *.titlesearch" params comment. Otherwise I'd say this can be included in 7.1.
well, by "barf" I mean it creates an error entry rather than giving results. Probably NOT something that can go directly into 7.1 unless the results are actually showing up now.
The titlesearch crash is fixed by this: --- Slim/Buttons/BrowseDB.pm (revision 40793) +++ Slim/Buttons/BrowseDB.pm (local) @@ -184,7 +184,7 @@ if ($levelName eq 'contributor') { - $field = 'contributor.titlesearch'; + $field = 'contributor.namesearch'; } elsif ($levelName eq 'album') { This now works for pressing PLAY. The problem now is that descending into the 'All' results runs the same search, so the results you get are wrong. Not sure how to fix this yet.
Checked in what we have so far as 7.1 change 21588.
given that the "all results" option is really only intended to allow you to play all of the results at once, can we not make it a non-descendable item and avoid the problem of re-running the search on descend?
Might be the best solution.
Fixed in 7.1 change 21622.
Verified to be fixed in 21814 ("All Albums").
This bug has now been fixed in the 7.1 release version of SqueezeCenter! Please download the new version from http://www.slimdevices.com if you haven't already. If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.
This bug has been fixed in the 7.3.0 release version of SqueezeCenter! Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already. If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.
Reduce number of active targets for SC